1325172 - Crash in nsNPAPIPluginInstance::WindowVolumeChanged

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-60e1f5f4-35b3-48c8-ac97-8b1dd2161221.
=============================================================

Seen while looking at Nightly crash data: http://bit.ly/2hWfmXh. Crashes started using the 20161221030226 build. Bug 1319529 is in the regression range - ni on :alwu

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1325172 - unregister agent when nsNPAPI releases it.

Review commit: https://reviewboard.mozilla.org/r/100374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100374/

Comment 2

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f54da63e79ae3f0d6d8c27adc2d9d6687d267e5

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8821062 [details]
Bug 1325172 - unregister agent when nsNPAPI releases it.

https://reviewboard.mozilla.org/r/100374/#review101042

I don't see why this is the correct fix.

::: dom/plugins/base/nsNPAPIPluginInstance.cpp:198
(Diff revision 1)
>  nsNPAPIPluginInstance::Destroy()
>  {
>    Stop();
>    mPlugin = nullptr;
> +  if (mAudioChannelAgent && mAudioChannelAgent->IsPlayingStarted()) {
> +    mAudioChannelAgent->NotifyStoppedPlaying();

This seems wrong. the DTOR of AudioChannelAgent calls Shutdown where we do:

  if (mIsRegToService) {
    NotifyStoppedPlaying();
  }

Comment 4

[Alastor Wu [:alwu]]

(In reply to Andrea Marchesini [:baku] from comment #3)
> This seems wrong. the DTOR of AudioChannelAgent calls Shutdown where we do:
> 
>   if (mIsRegToService) {
>     NotifyStoppedPlaying();
>   }

Ah, I forgot about that. If so, I need to re-think what's the crash reason.
Thanks!

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8821062 [details]
Bug 1325172 - unregister agent when nsNPAPI releases it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100374/diff/1-2/

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8821062 [details]
Bug 1325172 - unregister agent when nsNPAPI releases it.

https://reviewboard.mozilla.org/r/100374/#review101250

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dbe788ad153
unregister agent when nsNPAPI releases it. r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0dbe788ad153