Closed Bug 1325172 Opened 3 years ago Closed 3 years ago

Crash in nsNPAPIPluginInstance::WindowVolumeChanged

Categories

(Core :: Audio/Video: Playback, defect, P1, critical)

Unspecified
Windows 8
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: marcia, Assigned: alwu)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-60e1f5f4-35b3-48c8-ac97-8b1dd2161221.
=============================================================

Seen while looking at Nightly crash data: http://bit.ly/2hWfmXh. Crashes started using the 20161221030226 build. Bug 1319529 is in the regression range - ni on :alwu
Flags: needinfo?(alwu)
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Comment on attachment 8821062 [details]
Bug 1325172 - unregister agent when nsNPAPI releases it.

https://reviewboard.mozilla.org/r/100374/#review101042

I don't see why this is the correct fix.

::: dom/plugins/base/nsNPAPIPluginInstance.cpp:198
(Diff revision 1)
>  nsNPAPIPluginInstance::Destroy()
>  {
>    Stop();
>    mPlugin = nullptr;
> +  if (mAudioChannelAgent && mAudioChannelAgent->IsPlayingStarted()) {
> +    mAudioChannelAgent->NotifyStoppedPlaying();

This seems wrong. the DTOR of AudioChannelAgent calls Shutdown where we do:

  if (mIsRegToService) {
    NotifyStoppedPlaying();
  }
Attachment #8821062 - Flags: review?(amarchesini) → review-
(In reply to Andrea Marchesini [:baku] from comment #3)
> This seems wrong. the DTOR of AudioChannelAgent calls Shutdown where we do:
> 
>   if (mIsRegToService) {
>     NotifyStoppedPlaying();
>   }

Ah, I forgot about that. If so, I need to re-think what's the crash reason.
Thanks!
Comment on attachment 8821062 [details]
Bug 1325172 - unregister agent when nsNPAPI releases it.

https://reviewboard.mozilla.org/r/100374/#review101250
Attachment #8821062 - Flags: review?(amarchesini) → review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dbe788ad153
unregister agent when nsNPAPI releases it. r=baku
https://hg.mozilla.org/mozilla-central/rev/0dbe788ad153
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.