Closed Bug 1325237 Opened 6 years ago Closed 6 years ago

"google" is missing as a valid source for utm_source, for the Stub Attribution service whitelist

Categories

(Cloud Services :: Operations: Miscellaneous, task)

Product:
Cloud Services
Component:
Operations: Miscellaneous
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: stephend, Assigned: oremj)

References

Details

"google" isn't in https://bugzilla.mozilla.org/show_bug.cgi?id=1306457#c11 (so didn't make it to the Stub Attribution service whitelist, in https://github.com/mozilla-services/stubattribution/pull/23).

I found this today while testing, as I got the following exception[0]:

could not validate attribution_code: source%3Dgoogle%26medium%3Dpaidsearch%26campaign%3DBrand-US-GGL-Exact%26content%3D%28not+set%29%26timestamp%3D1482364920: source: google is not in whitelist

need-info?-ing :cmore to r? adding in "google", as by my testing, utm_source=google is a real value:

https://www.mozilla.org/en-US/firefox/new/?utm_source=google&utm_medium=paidsearch&utm_campaign=Brand-US-GGL-Exact&utm_term=download%20firefox&gclid=CjwKEAiA7ejCBRDlp8uF6ezPnjoSJAAPED7My_2tGZg1oeorhGcYkrARWn1mQMWpEaIzUq3yJwcJphoCS6Hw_wcB

[0] https://sentry.prod.mozaws.net/operations/stub_attribution-dev/issues/375124/
Flags: needinfo?(chrismore.bugzilla)
Assignee: nobody → oremj
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(chrismore.bugzilla)
Resolution: --- → FIXED
Verified FIXED; thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.