Pocket strings typo in es-MX and ast locales

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Pocket
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dmajor, Assigned: flod)

Tracking

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Comment 1

2 years ago
Pike, do you mind helping me route this to the right owners? I can provide a patch if needed, but I don't know how the process works for these things...
Flags: needinfo?(l10n)
(Assignee)

Comment 2

2 years ago
As a general rule for localization bugs: file one bug per locale since each locale is in a different component of Mozilla Localizations.

For this specific case I've fixed both strings in Pontoon, they will be committed here
https://github.com/mozilla-l10n/pocket-l10n/commits/master

The reality is that we need to dump them to mozilla-* code, and that's done manually.

@Shane
Can you help with that?
Flags: needinfo?(l10n) → needinfo?(mixedpuppy)
When you're ready, mkaply or myself can help.  Are you going to try and hit this uplift?  Will we want to uplift further?
Flags: needinfo?(mixedpuppy)
(Assignee)

Comment 4

2 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> When you're ready, mkaply or myself can help.  Are you going to try and hit
> this uplift?  Will we want to uplift further?

At this point I think we don't need to rush. Land mid-cycle next week, then uplift at least to aurora.
(Assignee)

Comment 5

2 years ago
Leave NI to myself to avoid forgetting about this bug.
Flags: needinfo?(francesco.lodolo)
Comment hidden (mozreview-request)
(Assignee)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

https://reviewboard.mozilla.org/r/107998/#review109110

::: browser/extensions/pocket/locale/en-US/pocket.properties:29
(Diff revision 1)
>  suggestedtags = Suggested Tags
>  tagline = Save articles and videos from Firefox to view in Pocket on any device, any time.
>  taglinestory_one = Click the Pocket Button to save any article, video or page from Firefox.
>  taglinestory_two = View in Pocket on any device, any time.
>  tagssaved = Tags Added
> -tos = By continuing, you agree to Pocket's <a href="%1$S" target="_blank">Terms of Service</a> and <a href="%2$S" target="_blank">Privacy Policy</a>
> +tos = By continuing, you agree to Pocket’s <a href="%1$S" target="_blank">Terms of Service</a> and <a href="%2$S" target="_blank">Privacy Policy</a>

Note sure why the current code doesn't have a proper curly apostrophe. This is a copy and paste from the string in the l10n repository.
(Assignee)

Updated

2 years ago
Assignee: nobody → francesco.lodolo
(Assignee)

Updated

2 years ago
Flags: needinfo?(francesco.lodolo)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

https://reviewboard.mozilla.org/r/108000/#review110050

In the future I think these should be pull requests against the git repo, then pulled into mc.
Attachment #8831416 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 9

2 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #8)
> In the future I think these should be pull requests against the git repo,
> then pulled into mc.

Uh, which Git repo? I must have missed that we had one, I'm only aware of the l10n repo (where these strings are coming from).
Keywords: checkin-needed
The repo is at https://github.com/mozilla-partners/pocket

We can backport from mc to git for this patch.
(Assignee)

Comment 11

2 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #10)
> The repo is at https://github.com/mozilla-partners/pocket
> 
> We can backport from mc to git for this patch.

OK, good to know for the future. I'll open PRs against that repo first.

Comment 12

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ec5fbdab74fb
Update Pocket string localizations, r=mixedpuppy
Keywords: checkin-needed
(Assignee)

Comment 14

2 years ago
Sorry, the last thing I was expecting was to have test failures on this kind of patch. I should know better.

Will fix and push to try before asking to land again.
Comment hidden (mozreview-request)
(Assignee)

Comment 16

2 years ago
Try builds seem green enough
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b4a1ca1c773
Flags: needinfo?(francesco.lodolo)
Keywords: checkin-needed
cc/mkaply on pocket stuff

Comment 18

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f98263256940
Update Pocket string localizations, r=mixedpuppy
Keywords: checkin-needed

Comment 19

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f98263256940
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Assignee)

Comment 20

2 years ago
Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

I think we can at least try to uplift this to aurora.

Approval Request Comment
[Feature/Bug causing the regression]: -

[User impact if declined]: Pocket name misspelled in es-MX and ast, missing a few localization updates.

[Is this code covered by automated tests?]: -

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no.

[Why is the change risky/not risky?]: it only affect localizations of Pocket.

[String changes made/needed]: these strings are not exposed for localization through the standard process.
Attachment #8831416 - Flags: approval-mozilla-aurora?
Since pocket-l10n is updated from pontoon, will these go in automatically?

https://github.com/mozilla-l10n/pocket-l10n
(Assignee)

Comment 22

2 years ago
(In reply to Mike Kaply [:mkaply] from comment #21)
> Since pocket-l10n is updated from pontoon, will these go in automatically?
> 
> https://github.com/mozilla-l10n/pocket-l10n

Pontoon commits directly to that repository. The strings from this patch are taken from there.

Updated

2 years ago
status-firefox53: --- → affected
Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

Fix Pocket string localization issue. Aurora53+.
Attachment #8831416 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 24

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f8f9621e75b
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.