comm-central should stop using nsIEditorIMESupport

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: masayuki, Assigned: Jorg K (GMT+2))

Tracking

({inputmethod})

Trunk
Thunderbird 53.0
inputmethod

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsIEditorIMESupport will be removed. So, comm-central should stop using it at:
https://dxr.mozilla.org/comm-central/rev/a844bb9580da7b60946d7592d772c7ef5b79da71/editor/ui/composer/content/ComposerCommands.js#891

Now, nsIEditor has all methods/attributes of nsIEditorIMESupport, so, it should just call |editor.forceCompositionEnd()|.

Although, I'm not sure if this code is actually used by Tb.
(Assignee)

Comment 1

6 months ago
Thanks for the heads-up. Maybe something in the HTML editor of SM. Philip can you please take a look.
Flags: needinfo?(philip.chee)
(Assignee)

Comment 2

6 months ago
Daniel, since you commented on bug 1312991, maybe you're interested in this one here, too.
Flags: needinfo?(daniel)
(In reply to Jorg K (GMT+1) from comment #2)
> Daniel, since you commented on bug 1312991, maybe you're interested in this
> one here, too.

Thanks for asking. BlueGriffon's code does not use nsIEditorIMESupport beyond
the editor core, so no objection at all.
Flags: needinfo?(daniel)

Comment 4

6 months ago
(In reply to Jorg K (GMT+1) from comment #1)
> Thanks for the heads-up. Maybe something in the HTML editor of SM. Philip
> can you please take a look.
Should not affect us.
Flags: needinfo?(philip.chee)
(Assignee)

Comment 5

6 months ago
Created attachment 8821515 [details] [diff] [review]
1325282-nsIEditorIMESupport.patch

Doing what Masayuki-san suggested.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8821515 - Flags: review?(philip.chee)

Comment 6

6 months ago
Comment on attachment 8821515 [details] [diff] [review]
1325282-nsIEditorIMESupport.patch

r=me. Sorry for the delay
Attachment #8821515 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 7

6 months ago
https://hg.mozilla.org/comm-central/rev/9bd6f256ea516c871c5a51ebc28d20c36b70cbc5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.