Closed Bug 1325284 Opened 9 years ago Closed 9 years ago

It isn't possible to directly link to a manifesto principle

Categories

(www.mozilla.org :: Bedrock, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: kohei)

References

()

Details

Attachments

(1 file)

44 bytes, text/x-github-pull-request
Details | Review
I'd like to be able to link to a particular principle in the manifesto. This does not seem to be possible without changes. This probably requires history API hacking, and I'm not familiar enough with the bedrock architecture to say whether individual pages are able to make unilateral changes to window.location.hash or whether there needs to be some sort of coordination. If it's the former, I'm happy to hack together a pull request. (BTW, the same goes for the search box. You can't link to a search either.)
Yeah we can actually link to each section, but should we probably pop up the overlay when such links are used? I implemented the page so happy to work on it.
Attached file pull request
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/f6f7fcffc3c2478f85c02f023d07672b90fce5e7 Fix Bug 1325284 - It isn't possible to directly link to a manifesto principle https://github.com/mozilla/bedrock/commit/0f27e01817a917bd39ee418b4013f21846c1c7b5 Merge pull request #4543 from kyoshino/bug-1325284-manifesto-hash Fix Bug 1325284 - It isn't possible to directly link to a manifesto principle
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: