Closed Bug 1325301 Opened 3 years ago Closed 3 years ago

Failure in 2.0.0/conformance2/rendering/attrib-type-match.html

Categories

(Core :: Canvas: WebGL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 3 obsolete files)

No description provided.
Comment on attachment 8821035 [details]
Bug 1325301 (flattened) - Validate attribute base types match data base types. -

https://reviewboard.mozilla.org/r/100406/#review100994

::: dom/webidl/WebGLRenderingContext.webidl
(Diff revision 1)
>      void vertexAttrib2f(GLuint indx, GLfloat x, GLfloat y);
> -    void vertexAttrib2fv(GLuint indx, Float32Array values);
> +    void vertexAttrib2fv(GLuint indx, Float32List values);
> -    void vertexAttrib2fv(GLuint indx, sequence<GLfloat> values);
>      void vertexAttrib3f(GLuint indx, GLfloat x, GLfloat y, GLfloat z);
> -    void vertexAttrib3fv(GLuint indx, Float32Array values);
> +    void vertexAttrib3fv(GLuint indx, Float32List values);
> -    void vertexAttrib3fv(GLuint indx, sequence<GLfloat> values);

Can you describe why you wanna change Float32Array with Float32List? In spec (https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14), it mentions VertexAttribFVSource should be Float32Array or sequence<GLfloat>.
This IDL changes here are non-functional. (both idls are equivalent)

I am proposing the simplified version here:
https://github.com/KhronosGroup/WebGL/pull/2221
Attachment #8821035 - Flags: review?(bzbarsky)
Comment on attachment 8821035 [details]
Bug 1325301 (flattened) - Validate attribute base types match data base types. -

https://reviewboard.mozilla.org/r/100406/#review101120

r=me on the webidl bit
Attachment #8821035 - Flags: review?(bzbarsky) → review+
Comment on attachment 8821035 [details]
Bug 1325301 (flattened) - Validate attribute base types match data base types. -

https://reviewboard.mozilla.org/r/100406/#review101164
Attachment #8821035 - Flags: review?(dmu) → review+
Comment on attachment 8821036 [details]
Bug 1325301 - Remove EnsureAttrib() and friends. -

https://reviewboard.mozilla.org/r/100408/#review101188

LGTM
Attachment #8821036 - Flags: review?(dmu) → review+
Comment on attachment 8821037 [details]
Bug 1325301 - Validate attribute base types match data base types. -

https://reviewboard.mozilla.org/r/100410/#review101192
Attachment #8821037 - Flags: review?(dmu) → review+
Comment on attachment 8821795 [details]
Bug 1325301 - Simplify EnumName behavior and usage and add ErrorInvalidEnumArg(). -

https://reviewboard.mozilla.org/r/100918/#review101562
Attachment #8821795 - Flags: review?(dmu) → review+
Attachment #8821036 - Attachment is obsolete: true
Attachment #8821037 - Attachment is obsolete: true
Attachment #8821795 - Attachment is obsolete: true
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0eb5a38f716
(flattened) - Validate attribute base types match data base types. - r=bz,daoshengmu
https://hg.mozilla.org/mozilla-central/rev/c0eb5a38f716
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.