Test for "a single keyframe sequence with string offset" has the wrong computedOffset

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM: Animation
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

This test case, added when merging Blink tests[1] expects an offset of '0.5' to produce an offset of 0.5 and a computedOffset of 1. That's clearly wrong.

[1] https://github.com/w3c/web-platform-tests/commit/e656c20e538a83efe94fdd26c3e5eb056b148c5f#diff-54ba468151a7d5a883fe7a9be379564c
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8821051 - Flags: review?(hiikezoe)
Attachment #8821052 - Flags: review?(hiikezoe)

Comment 3

a year ago
mozreview-review
Comment on attachment 8821051 [details]
Bug 1325308 - Fix expected computedOffset for 'a single keyframe sequence with string offset' test

https://reviewboard.mozilla.org/r/100432/#review100962
Attachment #8821051 - Flags: review?(hiikezoe) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8821052 [details]
Bug 1325308 - Convert non-promise test to use regular test() function

https://reviewboard.mozilla.org/r/100434/#review100966
Attachment #8821052 - Flags: review?(hiikezoe) → review+

Comment 5

a year ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f37791a9a92
Fix expected computedOffset for 'a single keyframe sequence with string offset' test r=hiro
https://hg.mozilla.org/integration/autoland/rev/c09596126766
Convert non-promise test to use regular test() function r=hiro

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f37791a9a92
https://hg.mozilla.org/mozilla-central/rev/c09596126766
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.