1325313 - Reader View button missing voiceover

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Sankararaman]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/602.3.12 (KHTML, like Gecko) Version/10.0.2 Safari/602.3.12

Steps to reproduce:

Load webpage with Reader Mode available



Actual results:


Sighted user noticed reader mode button appeared.
VoiceOver user did not notice it, unless they took the effort to with VoiceOver cursor to the location bar.



Expected results:

Sighted user noticed reader mode button appeared.
VoiceOver user noticed availability of Reader Mode without any effort  as VoiceOver spoke announcement that Reader Mode is available (this is what Safari does).

Comment 1

[Andre Klapper]

Thanks for reporting this.
Please edit the task summary to actually summarize the "bug in firefox iOS" that you experience.

Comment 2

[Aaron Train [:aaronmt]]

Re-summarized based on my interpretation. 

I'm pretty sure our Reader View button (when available via certain content) is marked an accessibility element and has an accessibility hint and accessibility label. If that's not the case, it should be trivial to add.

What device, iOS version and version of Firefox are you using @Sankararaman?

Comment 3

[Sankararaman]

iOS 9

Comment 4

[Simon Basca [:SimonB]]

Tested on iPhone SE (9.3.2) and iPhone 7(10.0.1). 

When opening a page with reader mode available VoiceOver does not notice it in Firefox. This is not the case in Safari. VoiceOver notices reader mode when available.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Stephan, I wasn't sure if anything additional needs to be done with this patch because it requires a new localized string for the VoiceOver announcement. Let me know if I'm missing anything.

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8844637 [details] [review]
GitHub Pull Request

Just a minor comment about cleaning up the localized string but other than that looks good. We won't be able to land this in 7.0 though since it does introduce a new string.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/3cefc233c019f696a86d0378e8dfbdf56f7acb7a