1325376 - Button labels in container dialog not exposed to assistive technology users

Status: RESOLVED WORKSFORME

(Firefox :: Disability Access, defect)

Description

[am_dxer]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161221030226

Steps to reproduce:

1. Select the File menu.
2. Select New Container Tab.
3. Select Manage Containers.


Actual results:

When using the Tab key to navigate this dialog. The buttons associated with each container tab are spoken by assistive technologies as button


Expected results:

The buttons should be labeled for assistive technology users.

Comment 1

[Marco Zehe (:MarcoZ)]

Gijs, what's the best component to put this UI bug in?

Comment 2

[:Gijs (he/him)]

(In reply to Marco Zehe (:MarcoZ) (Returns Jan 9, 2017) from comment #1)
> Gijs, what's the best component to put this UI bug in?

I'm not sure without looking into this in more detail to see what the issue is. I did already look in the past, but the button markup looked fine to me, so I don't understand why it wouldn't work - which might be a Core bug, unless someone can explain in more detail what's wrong with the markup as is. It's also possible this got fixed in bug 1315458, which changed some of the markup. It's also not 100% clear to me *which* buttons (there are rather a lot in this dialog) aren't getting the right accessible title / name. Can you take a look?

Comment 3

[am_dxer]

I noticed that after my nightly updated, the buttons are now correctly labeled. I did notice, however, that nothing is voiced when using the arrow keys to navigate the list of containers in this same dialog.

Comment 4

[:Gijs (he/him)]

(In reply to am_dxer from comment #3)
> I noticed that after my nightly updated, the buttons are now correctly
> labeled. I did notice, however, that nothing is voiced when using the arrow
> keys to navigate the list of containers in this same dialog.

I don't think you can navigate the list with the arrow keys. The individual items are not focusable/selectable, only the buttons are. If focus is correctly moving from button to button if you're using the arrow keys, and things get read if you do that with tab/shift-tab, but not read if you use the arrow keys, then I wouldn't really know what's going on...

Comment 5

[Marco Zehe (:MarcoZ)]

These buttons now work, so this bug can be closed as WORKSFORME. However that other part of the UI where there is a non-navigable list with only a few buttons really needs some additional love. When tabbing through, you never know what Preferences item you are editing or deleting. Also, the fact that this thing still says "list" even though it isn't navigable is just plain wrong. :-)

Comment 6

[:Gijs (he/him)]

(In reply to Marco Zehe (:MarcoZ) from comment #5)
> However
> that other part of the UI where there is a non-navigable list with only a
> few buttons really needs some additional love. When tabbing through, you
> never know what Preferences item you are editing or deleting. Also, the fact
> that this thing still says "list" even though it isn't navigable is just
> plain wrong. :-)

Can you file a new bug that blocks bug 1267916 and bug 1191418 with some more details about how you think this *should* work?

Comment 7

[Marco Zehe (:MarcoZ)]

Done, bug 1329643.

Closing this bug as WORKSFORME, see comment #3.