1325378 - Clicking outside the sharing doorhanger will not remember the last chosen application (window) in the sharing drop down

Status: NEW

(Firefox :: Site Permissions, defect, P3)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- latest Aurora 52.0a2 (2016-12-22)
- 51.0b9 (20161219140923)
- 50.1.0 (20161208153507)

[Affected platforms]:
- Mac OS X 10.12.1
- Ubuntu 14.04 x86
- Windows 10 x64   

[Steps to reproduce]:
1. Lanuch Firefox
2. Navigate to about:config and confirm that:
   * media.getusermedia.screensharing.allow_on_old_platforms is false;
   * media.getusermedia.screensharing.enabled is true 
   * media.getusermedia.screensharing.allowed_domains is set to many different websites, including mozilla.github.io
3. Go to https://mozilla.github.io/webrtc-landing/gum_test.html 
- have al least one more open applications
4. Click the Application button (or the Window button)
5. Choose the desired application from the "Application to share" drop down (or the desired window from the "Window to share" drop down)
6. Click outside the doorhanger
7. Click the share screen icon from the location bar in order to reopen the sharing doorhanger
- inspect the displayed entry in the sharing drop-down (and the sharing preview - for 52 builds)

[Expected result]:
- The chosen option from step 5 is remembered until the sharing doorhanger is reopen

[Actual result]:
- When the doorhanger is reopen, "No Application" ("No Window") entry is displayed
- This also causes the sharing preview closing (for 52 builds)

[Regression range]:
- This issue is not a recent regression, as is reproducible all the way back to Firefox 42

[Additional notes]:
- The issue is not reproducible on 53 builds, as the doorhanger stays open even when clicking outside it

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

This may be "working as expected/designed" - florian?

Comment 2

[Florian Quèze [:florian]]

(In reply to Iulia Cristescu, QA [:IuliaC] from comment #0)

> [Additional notes]:
> - The issue is not reproducible on 53 builds, as the doorhanger stays open
> even when clicking outside it

This isn't entirely true: if you tweak slightly the steps to reproduce to say "click outside of the window" instead of "click outside of the doorhanger", then "No Application" will get reselected on 53 too. This is something I'm tracking/fixing in bug 1325223.

Comment 3

[Florian Quèze [:florian]]

(In reply to Randell Jesup [:jesup] from comment #1)
> This may be "working as expected/designed" - florian?

Generally, yes, this is working as expected. We expect to clear the selection when the doorhanger is closed and reopened. What I mentioned in comment 2 is the only part that in my opinion needs fixing.

Comment 4

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.