Prune obsolete B2G components from Fennec's package manifest

RESOLVED FIXED

Status

Firefox Build System
General
P3
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: mds, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Some of the components in Fennec's package manifest are obsolete and not present anymore (see bug nukeb2g).
Comment hidden (mozreview-request)
Does this allow to build with MOZ_PKG_FATAL_WARNINGS = 1 set in mobile/android/installer/Makefile.in?
(In reply to Mike Hommey [:glandium] from comment #2)

> Does this allow to build with MOZ_PKG_FATAL_WARNINGS = 1 set in
> mobile/android/installer/Makefile.in?

Nope.

bin/libnssdbm3.so, bin/blocklist.xml and bin/components/components.manifest are still missing but not part of nukeb2g.
Summary: Prune obsolete components from Fennec's package manifest → Prune obsolete B2G components from Fennec's package manifest

Comment 4

2 years ago
mozreview-review
Comment on attachment 8821326 [details]
Bug 1325478 - Prune obsolete B2G components from Fennec's package manifest.

https://reviewboard.mozilla.org/r/100632/#review101694

As good as this looks, I'm not an expert on the Fennec code. I'm going to defer this review to Stefan.

::: mobile/android/installer/package-manifest.in:84
(Diff revision 1)
>  @BINPATH@/classes.dex
>  
>  [browser]
>  ; [Base Browser Files]
>  @BINPATH@/application.ini
> -@BINPATH@/platform.ini
> +    @BINPATH@/platform.ini

This whitespace change seems unwanted.
Attachment #8821326 - Flags: review?(gps)

Updated

2 years ago
Attachment #8821326 - Flags: review?(sarentz)
Comment hidden (mozreview-request)
Duplicate of this bug: 1332804
Attachment #8821326 - Flags: review?(sarentz) → review?(s.kaspari)
Deflecting to Sebastian, who can find the right reviewer for this.

Comment 8

a year ago
mozreview-review
Comment on attachment 8821326 [details]
Bug 1325478 - Prune obsolete B2G components from Fennec's package manifest.

https://reviewboard.mozilla.org/r/100632/#review112332
Attachment #8821326 - Flags: review?(s.kaspari) → review+
No longer blocks: 1369194
Any reason we shouldn't land this?
Flags: needinfo?(mdesimone)
(In reply to Mike Taylor [:miketaylr] (55 Regression Engineering Owner) from comment #9)

> Any reason we shouldn't land this?

Even though I have been out of the this loop for some time I don't think there's any real blocker on this.
The desktop manifest was updated long ago so my take is that - if releng is fine with this - we can definitely go ahead.:)
Flags: needinfo?(mdesimone)
(Reporter)

Updated

10 months ago
Assignee: michel → nobody

Comment 11

5 months ago
I was just going through our bug backlog and it looks like the patch doesn't apply anymore and the older entries in the package manifest are removed.
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.