Closed Bug 1325530 Opened 3 years ago Closed 2 years ago

Intermittent browser/base/content/test/tabcrashed/browser_shown.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])

Attachments

(1 file)

is this perma fail, can we back this out :KWierso?
Flags: needinfo?(wkocher)
Whiteboard: [stockwell needswork]
Not permafailing. I'd say it's about 50% failure rate. 

And I was wrong in comment 3. The chunk the test runs in keeps shifting, so it only looked like that backout merge caused the spike. I can try further tracking down where this started.
Flags: needinfo?(wkocher)
Flags: needinfo?(mconley)
Depends on: 1378036
This was a long-running test before mconley's change:

Test durations for browser/base/content/test/tabcrashed/browser_shown.js on mozilla-central,mozilla-inbound,autoland between 2017-07-11 and 2017-07-18
linux32/debug-e10s:            103.66 s (82.71 s - 123.08 s over 193 runs)
linux32/opt-e10s:               24.69 s (20.94 s - 47.71 s over 231 runs)
linux64/debug-e10s:             97.67 s (79.46 s - 138.65 s over 285 runs)

With those durations, it seems odd that frequent failures were not reported earlier.

Regardless, we have the standard options: Find a way to optimize or simplify the test, split it up into 2 or more tests, or requestLongerTimeout(). 

Hoping mconley has time to fix this soon...
The simplest "solution"!

Also, I noticed https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/browser/base/content/test/tabcrashed/browser_showForm.js#5 and other tabcrashed tests already requestLongerTimeout().
Attachment #8890021 - Flags: review?(mconley)
Comment on attachment 8890021 [details] [diff] [review]
requestLongerTimeout

Review of attachment 8890021 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8890021 - Flags: review?(mconley) → review+
Flags: needinfo?(mconley)
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0a02adc8689
requestLongerTimeout for browser_shown.js; r=mconley
https://hg.mozilla.org/mozilla-central/rev/d0a02adc8689
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Whiteboard: [stockwell needswork] → [stockwell fixed:timing]
See Also: → 1394715
Assignee: nobody → gbrown
You need to log in before you can comment on or make changes to this bug.