MPI assembler isn't compiled on Android after moving to GYP

RESOLVED FIXED in 3.29

Status

NSS
Build
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

trunk
3.29
Unspecified
Android

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Before moving to GYP, we use MPI assembler (x86 and arm) even if Android.  But after moving to it, it isn't compiled.  This will cause performance issue on encryption/decryption.
(Assignee)

Comment 1

2 years ago
On GYP, Android is OS=="Android", not OS=="Linux"
(Assignee)

Comment 2

2 years ago
Created attachment 8821447 [details] [diff] [review]
MPI assembler isn't compiled on Android after moving to GYP. r?ted
Attachment #8821447 - Flags: review?(ted)
(Assignee)

Updated

2 years ago
Attachment #8821447 - Attachment is obsolete: true
Attachment #8821447 - Flags: review?(ted)
(Assignee)

Comment 3

2 years ago
Created attachment 8821448 [details] [diff] [review]
MPI assembler isn't compiled on Android after moving to GYP. r?ted

Even if OS=="android", we should compile MPI assembler.
Attachment #8821448 - Flags: review?(ted)
Comment on attachment 8821448 [details] [diff] [review]
MPI assembler isn't compiled on Android after moving to GYP. r?ted

Review of attachment 8821448 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Sorry, sorting out all of the conditionals in the NSS Makefiles was difficult, and I was primarily focused on our Tier-1 platforms.
Attachment #8821448 - Flags: review?(ted) → review+
Assignee: nobody → m_kato
(Assignee)

Comment 5

2 years ago
set checkin-needed flag because I have no permission for NSS repository.
Keywords: checkin-needed
https://hg.mozilla.org/projects/nss/rev/7b9f0d09ca8b4d88d99b36d5e0806831fe70b8a5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.29
You need to log in before you can comment on or make changes to this bug.