1325557 - RDM can be enabled on non-remote pages

Status: RESOLVED INVALID

(DevTools :: Responsive Design Mode, defect)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

[Notes]:
Follow up from bug 1274032.

[Affected versions]:
- Firefox 52.0a2 (2016-12-22), Firefox 53.0a1 (2016-12-22)

[Affected platforms]:
- Ubuntu 16.04x64, Windows 8.1x86, Mac 10.12.1

[Steps to reproduce]:
Prerequisites: Make sure that devtools.responsive.html.enabled pref is set to true.

1. Launch Firefox.
2. Go to a non-remote page (eg. about:home).
3. Enable RDM

[Expected result]:
- An error notification is displayed and RDM is not enabled.

[Actual result]:
- RDM is enabled and no notification is displayed.

[Regression range]:
- This is not a regression.

[Additional notes]:
- This issue is also reproducible on about:plugins, about:privatebrowsing, about:serviceworkers non remote pages.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

These pages actually _are_ remote, so this behavior is fine.  It's pretty confusing, but some about pages are loaded remotely and others are not.  For example, about:newtab and about:addons currently are not remote.

One simple way to check if a tab was loaded remotely is to hover on the tab title and check the tooltip.  If the tab is loaded remotely, the tooltip should have the suffix "- e10s".