1325590 - Get rid of LAYER_SVG_EFFECTS for masks entirely

Status: RESOLVED INVALID

(Core :: Web Painting, defect)

Description

[u459114]

Bug 1325550 Comment 7:
LAYER_INACTIVE means that we use a mask layer in the temporary BasicLayerManager that's created for the inactive display item. So we will apply the mask on the main thread during painting, and not on the Compositor.
Applying mask layers in BasicLayerManager does very similar things to what nsSVGIntegrationUtils::PaintMaskAndClipPath does. There's not a good reason that it should be any slower. We should find out why it's slower and fix it, so that we can get rid of LAYER_SVG_EFFECTS for masks entirely.

In another word, we should figure out why applying mask layer in BasicLayerManager  is slower than nsSVGIntegrationUtils::PaintMaskAndClipPath

Comment 1

[u459114]

And then use LAYER_SVG_EFFECTS with nsDisplayFilter only(rename to LAYER_FILTER?)

Comment 2

[u459114]

Test case from mstange:
https://bug1325550.bmoattachments.org/attachment.cgi?id=8821497

Comment 3

[u459114]

Compare perf between BasicLayerManager::PushGroupForLayer and nsSVGIntegrationUtils::CreateAndPaintMask

Comment 4

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9130ded1da5

Comment 5

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26d91a3b7b9

Comment 6

[u459114]

Attachment: Bug 1325590 - Get rid of LAYER_SVG_EFFECT in nsDisplayMask.

Review commit: https://reviewboard.mozilla.org/r/101118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101118/

Comment 7

[u459114]

(In reply to C.J. Ku[:cjku](UTC+8) from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26d91a3b7b9
Still need to fix opacity assertion, overall looks good, except fuzzy around shape edge

Comment 8

[Thomas Wisniewski [:twisniewski]]

LAYER_SVG_EFFECTS doesn't seem to be in the codebase anymore (at least I don't see it on searchfox), so I think this is no longer a valid bug.