132564 - Applets sized using % do not resize with browser window

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Ed Buck]

As of MRJPlugin version 1.0d7, it was possible to specify applet size using 
percentages (i.e height=100% width=100%).  However, when percentages are used, 
the expected behavior is for the applet to automatically resize/repaint when 
the browser window is resize.  With the latest version of the MRJPlugin 
(1.0b2), applets do not resize with the window.  The user must refresh the 
browser window to get the applet to resize.

Comment 1

[Patrick C. Beard]

Brian, looks like we need to add code to call SizeJavaControl whenever the
width/height of the plugin window changes.

Comment 2

[Brian Nesse (gone)]

Ed, do you have a test case for this?

Comment 3

[Ed Buck]

Attachment: Java source file for test case

Comment 4

[Ed Buck]

Attachment: HTML file for test case

Comment 5

[Ed Buck]

Attachment: Class file for test case

Comment 6

[Brian Nesse (gone)]

Attachment: Proposed patch

Patch to call SizeJavaControl() before calling MoveAndClipJavaControl() (which
seems a bit silly IMO... but it does work.

Comment 7

[Steve Dagley]

Comment on attachment 76064 [details] [diff] [review]
Proposed patch

if (silly && works)
  r=sdagley

Comment 8

[Patrick C. Beard]

Comment on attachment 76064 [details] [diff] [review]
Proposed patch

you should use the width & height fields from the nsPluginWindow struct.

Comment 9

[Brian Nesse (gone)]

Attachment: Revised patch

Patch addressing beards comments. Patch also removes surrounding ifdefs and
dead code.

Comment 10

[Brian Nesse (gone)]

Attachment: Patch without extra crap from other patches.

Comment 11

[Steve Dagley]

Comment on attachment 76131 [details] [diff] [review]
Patch without extra crap from other patches.

r=sdagley

Comment 12

[Patrick C. Beard]

Comment on attachment 76131 [details] [diff] [review]
Patch without extra crap from other patches.

sr=beard

Comment 13

[Brian Nesse (gone)]

Checked in.

Comment 14

[Patty Mac]

Chris Petersen is a new QA contact for oji component. His email is:
[e-mail]

Comment 15

[Matthias Versen [:Matti]]

fixing small error for [e-mail] (filter with : SPAMMAILSUCKS)

Comment 16

[Chris Petersen]

Verified in the 2002-12-17-08 cfm trunk under OS X 10.2.3.