1325699 - Failures in 2.0.0/deqp/functional/gles3/uniformbuffers/

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1325699 - Fix uniform block handling. -

Review commit: https://reviewboard.mozilla.org/r/100852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100852/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1325699 - Handle -1 attrib locations. -

Review commit: https://reviewboard.mozilla.org/r/100920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100920/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8821636 [details]
Bug 1325699 - Fix uniform block handling. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100852/diff/1-2/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8821636 [details]
Bug 1325699 - Fix uniform block handling. -

https://reviewboard.mozilla.org/r/100852/#review101554

LGTM

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8821798 [details]
Bug 1325699 - Handle -1 attrib locations. -

https://reviewboard.mozilla.org/r/100920/#review101556

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c274a7c25dc7
(flattened) - Fix uniform block handling. - r=daoshengmu

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c274a7c25dc7

Comment 8

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b213de949cdd

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/31e8e7e5ef88