1325705 - Middle click to paste in main window does not work for protocol-less file paths anymore

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[cloos]

(I don’t know when this stopped working, but I suspect it stopped working with the 50 branch.)

In ff 50.0 and 50.1, middle click now only works if PRIMARY is a url.

It also used to work for files.  Ie, pasting /tmp/foo.html used to open that file.  Now it only works if you paste file:///tmp/foo.html .

The code which matches pastes before trying to open them should treat the re:

  ^file://

as optional, not as required.  (However it does the matching.)

Comment 1

[YF (Yang)]

ref: related pref is middlemouse.contentLoadURL

Comment 2

[u554753]

"as optional, not as required.  (However it does the matching.)" 

Can you clarify what this means?

Comment 3

[:Gijs (he/him)]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #2)
> "as optional, not as required.  (However it does the matching.)" 
> 
> Can you clarify what this means?

comment #0 assumes we do some kind of regular expression matching against the clipboard when the user middle-clicks, and indicates we should allow for a file path starting with '/' (on *nix-like OSes) without a "file://" prefix.

This isn't how that code works.

Someone just needs to find out when this regressed and thereby what broke this, hence the keywords I added.

Comment 4

[Stefan [:StefanG_QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:2.2a1pre) Gecko/20110412 Firefox/4.2a1pre
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

I have tested the issue on latest FF release (50.1.0) and latest Nightly build and could not reproduce it. I've used mozregression to test the issue on versions 45; 40; 35; 30; 20; 10 and even on 4. Still could not reproduce it.

Could you please retest this using latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E).

Comment 5

[:Gijs (he/him)]

Closing this out as there's been no response from the reporter.