Closed Bug 1325723 Opened 5 years ago Closed 5 years ago

Rename Windows clang-cl builds to st-an to make them more consistent with other static analysis builds

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: 1325719
Depends on: 1251936
Comment on attachment 8821690 [details] [diff] [review]
Rename Windows clang-cl builds to st-an to make them more consistent with other static analysis builds

Review of attachment 8821690 [details] [diff] [review]:
-----------------------------------------------------------------

Does this make them consistent with Buildbot?  Did Buildbot even have names for these, however briefly, or did that support even land?

Patch seems OK to me assuming that the answer to the second question about is "no", but I would feel more comfortable if Dustin reviewed this; I know I have tried changing the names in windows.yml without any change on treeherder, so maybe there are sekret Taskcluster things I don't know about?
Attachment #8821690 - Flags: review?(nfroyd)
Attachment #8821690 - Flags: review?(dustin)
Attachment #8821690 - Flags: review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8821690 [details] [diff] [review]
> Rename Windows clang-cl builds to st-an to make them more consistent with
> other static analysis builds
> 
> Review of attachment 8821690 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this make them consistent with Buildbot?  Did Buildbot even have names
> for these, however briefly, or did that support even land?

I don't think Buildbot compat (with Windows static analysis builds) is important, given that I'm removing the Buildbot jobs in bug 1325726 and they've not been used for anything.

> Patch seems OK to me assuming that the answer to the second question about
> is "no", but I would feel more comfortable if Dustin reviewed this; I know I
> have tried changing the names in windows.yml without any change on
> treeherder, so maybe there are sekret Taskcluster things I don't know about?

Dustin's review is good idea!
Comment on attachment 8821690 [details] [diff] [review]
Rename Windows clang-cl builds to st-an to make them more consistent with other static analysis builds

Review of attachment 8821690 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/build/windows.yml
@@ +113,5 @@
>          script: mozharness/scripts/fx_desktop_build.py
>          config:
>              - builds/taskcluster_firefox_windows_64_opt.py
>  
> +win32-st-an/debug:

Hm, now that it's a little clearer what this is, it should be in the "static-analysis' kind just like for bug 1328459.  In which case, the job name change is just fine.
Comment on attachment 8821690 [details] [diff] [review]
Rename Windows clang-cl builds to st-an to make them more consistent with other static analysis builds

Review of attachment 8821690 [details] [diff] [review]:
-----------------------------------------------------------------

r+ to this change.  If you want to move the st-an to the right kind in a separate bug, that's fine by me (but please do move!).  Sorry I didn't cotton on to what these tasks were until just now.
Attachment #8821690 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #4)
> Comment on attachment 8821690 [details] [diff] [review]
> Rename Windows clang-cl builds to st-an to make them more consistent with
> other static analysis builds
> 
> Review of attachment 8821690 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/ci/build/windows.yml
> @@ +113,5 @@
> >          script: mozharness/scripts/fx_desktop_build.py
> >          config:
> >              - builds/taskcluster_firefox_windows_64_opt.py
> >  
> > +win32-st-an/debug:
> 
> Hm, now that it's a little clearer what this is, it should be in the
> "static-analysis' kind just like for bug 1328459.  In which case, the job
> name change is just fine.

Yes, I'll move them in a follow-up.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46e3b55396a1
Rename Windows clang-cl builds to st-an to make them more consistent with other static analysis builds; r=froydnj,dustin
https://hg.mozilla.org/mozilla-central/rev/46e3b55396a1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.