132584 - Using "my chosen colors" prevents syntax highlighting from working

Status: RESOLVED EXPIRED

(Core Graveyard :: View Source, defect)

Description

[Erich 'Ricky' Iseli]

Tested in build 2002-03-18 (08) on Linux

1. Go to Edit>Preferences>Appearance>Colors
2. Choose "Use my chosen colors, ignoring the colors and background image specified"
3. Make sure "Enable Syntax Highlighting" is selected
4. View the source of a page
=> Syntax highlighting is not working

If you set back to "Always use the colors and background specified by the web
page", the syntax highlighting works again.

The color prefs should only apply to _web_pages_ and not to internally generated
stuff, like the view-source.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Over to me.  view-source is indeed a web page as far as anything but the parser
is concerned, so we apply the pref....

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 149833 has been marked as a duplicate of this bug. ***

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bit of a hack, but....

Comment 4

[Boris Zbarsky [:bzbarsky]]

jst?  heikki?  What do you think of that approach? It seemed a lot cleaner than
messing around with the tag listener stuff... and that's the only other way I
can get at the presshell from the parser.

Comment 5

[Boris Zbarsky [:bzbarsky]]

going on vacation

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 97378 [details] [diff] [review]
Bit of a hack, but....

This needs merging to current trunk, but the patch will look exactly the same,
so soliciting review on the approach.  ;)

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 97378 [details] [diff] [review]
Bit of a hack, but....

sr=jst

Comment 8

[Boris Zbarsky [:bzbarsky]]

If someone has time to update that patch to tip, that would be nice.  But I have
no plans to work on this in the foreseeable future.

Comment 9

[Boris Zbarsky [:bzbarsky]]

No plans to work on this any time in the foreseeable future, so to default owner.

Comment 10

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 11

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420