Closed
Bug 1325858
Opened 7 years ago
Closed 7 years ago
Redundant handles open for HKLM\SYSTEM\ControlSet001\Control\TimeZoneInformation
Categories
(Core :: Internationalization, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bugzilla.mozilla.org, Assigned: longsonr)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.41 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
I'm seeing approximately 2100 open registry key handles in process explorer for "TimeZoneInformation". I'm not experiencing any particular problems due to that but it seems to indicate a leak or something that needs a singleton.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → longsonr
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8821887 -
Flags: review?(andrebargull)
|
||
Updated•7 years ago
|
Priority: -- → P3
See Also: → http://bugs.icu-project.org/trac/ticket/12908
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8821887 [details] [diff] [review] patch Review of attachment 8821887 [details] [diff] [review]: ----------------------------------------------------------------- The change looks reasonable, but in order to r+ the fix, the ICU patch itself also needs to be added to the tree [1] and then appended to the list of patch files in [2]. (The patch file should also contain a small description explaining the change and a link to https://ssl.icu-project.org/trac/ticket/12908, similar to the comment in [3]). We store our ICU modifications as patch files, so we can more easily update to another ICU version without losing all custom changes. [1] https://dxr.mozilla.org/mozilla-central/source/intl/icu-patches [2] https://dxr.mozilla.org/mozilla-central/rev/dccfc624915b1bebe7975076e9b42bd46684cbc6/intl/update-icu.sh#58 [3] https://dxr.mozilla.org/mozilla-central/source/intl/icu-patches/unum_formatDoubleForFields.diff#1-3
Attachment #8821887 -
Flags: review?(andrebargull) → review-
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8821887 -
Attachment is obsolete: true
Attachment #8822181 -
Flags: review?(andrebargull)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8822181 [details] [diff] [review] address review comments Review of attachment 8822181 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8822181 -
Flags: review?(andrebargull) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db8454d1294f1d45f2d9a405ae2f14fcf66ba0f5&selectedJob=65492820
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8494bff5a731 Redundant handles open for HKLM\SYSTEM\ControlSet001\Control\TimeZoneInformation r=andrebargull
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8494bff5a731
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•