Closed
Bug 1325883
Opened 7 years ago
Closed 7 years ago
Internal RTL pages warning icon should appear at the right side on RTL builds
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: tomer, Assigned: tomer)
References
()
Details
Attachments
(1 file)
On LTR builds the warning icon appears on the left side. We wish to have the icon on the right side on RTL builds, similar to how we dealt it on about:config other about: pages.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8822099 -
Flags: review?(dao+bmo)
|
||
Comment 2•7 years ago
|
||
So the problem here is that :-moz-locale-dir doesn't work in all pages using info-pages.inc.css?
Flags: needinfo?(tomer.moz.bugs)
|
|
Assignee | |
Comment 3•7 years ago
|
||
:-moz-locale-dir() is required for XUL-based pages, and :dir() is required for HTML-based. We need both because we have both.
Flags: needinfo?(tomer.moz.bugs)
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8822099 -
Flags: review?(jaws)
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8822099 [details] Bug 1325883 - about:sessionrestore warning icon should appear at the right side on RTL builds https://reviewboard.mozilla.org/r/101110/#review102564
Attachment #8822099 -
Flags: review?(jaws) → review+
|
|
||
Updated•7 years ago
|
Attachment #8822099 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b19980534a44 about:sessionrestore warning icon should appear at the right side on RTL builds r=jaws
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b19980534a44
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•