Closed Bug 1325894 Opened 7 years ago Closed 7 years ago

Devirtualize StateObject::HandleNotDecoded()

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

http://searchfox.org/mozilla-central/rev/39f45e8015056b1fc2de3f85250360666cf2d275/dom/media/MediaDecoderStateMachine.cpp#1743

HandleNotDecoded() is a virtual function which calls other virtual functions like HandleWaitingForData() or HandleEndOfStream().

It is hard to trace the call flow when some sub-classes override HandleNotDecoded() and some others override HandleWaitingForData() or HandleEndOfStream().

We would like to have only pure virtual functions or concrete functions in the base class.
Assignee: nobody → jwwang
Blocks: 1324999
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.