Closed Bug 1325905 Opened 3 years ago Closed 3 years ago

Remove calls to MDSM::Ensure{Audio,Video}DecodeTaskQueued from DecodingFirstFrameState

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(7 files)

Ensure{Audio,Video}DecodeTaskQueued checks mState and break the encapsulation. DecodingFirstFrameState should just call Request{Audio,Video} to decode first frames.
Assignee: nobody → jwwang
Blocks: 1324999
Attachment #8821956 - Flags: review?(kaku)
Attachment #8821957 - Flags: review?(kaku)
Attachment #8821958 - Flags: review?(kaku)
Attachment #8821959 - Flags: review?(kaku)
Attachment #8821960 - Flags: review?(kaku)
Attachment #8821961 - Flags: review?(kaku)
Attachment #8821962 - Flags: review?(kaku)
Comment on attachment 8821957 [details]
Bug 1325905. Part 2 - move IsWaitForDataSupported() assertions into MediaDecoderReaderWrapper.

https://reviewboard.mozilla.org/r/101036/#review101760

You don't want the MDSM to care about "IsWaitForDataSupported()", how about just remove it form reader wrapper?
Attachment #8821957 - Flags: review?(kaku) → review+
Comment on attachment 8821958 [details]
Bug 1325905. Part 3 - split HandleNotDecoded() into HandleAudioNotDecoded() and HandleVideoNotDecoded().

https://reviewboard.mozilla.org/r/101038/#review101766
Attachment #8821958 - Flags: review?(kaku) → review+
Comment on attachment 8821956 [details]
Bug 1325905. Part 1 - add assertions to MDSM::Request{Audio,Video}Data.

https://reviewboard.mozilla.org/r/101034/#review101768
Attachment #8821956 - Flags: review?(kaku) → review+
Comment on attachment 8821959 [details]
Bug 1325905. Part 4 - let DecodingFirstFrameState override Handle{Audio,Video}NotDecoded.

https://reviewboard.mozilla.org/r/101040/#review101762
Attachment #8821959 - Flags: review?(kaku) → review+
Comment on attachment 8821960 [details]
Bug 1325905. Part 5 - let DecodingFirstFrameState override Handle{Audio,Video}Waited.

https://reviewboard.mozilla.org/r/101042/#review101770
Attachment #8821960 - Flags: review?(kaku) → review+
Comment on attachment 8821961 [details]
Bug 1325905. Part 6 - let DecodingFirstFrameState::Enter() call Request{Audio,Video} instead.

https://reviewboard.mozilla.org/r/101044/#review101772
Attachment #8821961 - Flags: review?(kaku) → review+
Comment on attachment 8821962 [details]
Bug 1325905. Part 7 - add assertions to ensure Ensure{Audio,Video}DecodeTaskQueued is never called by DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/101046/#review101774
Attachment #8821962 - Flags: review?(kaku) → review+
Comment on attachment 8821957 [details]
Bug 1325905. Part 2 - move IsWaitForDataSupported() assertions into MediaDecoderReaderWrapper.

https://reviewboard.mozilla.org/r/101036/#review101760

Good point! I will remove the function.
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dce407eb2097
Part 1 - add assertions to MDSM::Request{Audio,Video}Data. r=kaku
https://hg.mozilla.org/integration/autoland/rev/6cc82c8ec58f
Part 2 - move IsWaitForDataSupported() assertions into MediaDecoderReaderWrapper. r=kaku
https://hg.mozilla.org/integration/autoland/rev/baa5c68871ef
Part 3 - split HandleNotDecoded() into HandleAudioNotDecoded() and HandleVideoNotDecoded(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/26f72dcb2f40
Part 4 - let DecodingFirstFrameState override Handle{Audio,Video}NotDecoded. r=kaku
https://hg.mozilla.org/integration/autoland/rev/fc9bd237bd08
Part 5 - let DecodingFirstFrameState override Handle{Audio,Video}Waited. r=kaku
https://hg.mozilla.org/integration/autoland/rev/5da156cd377b
Part 6 - let DecodingFirstFrameState::Enter() call Request{Audio,Video} instead. r=kaku
https://hg.mozilla.org/integration/autoland/rev/1ac358b52045
Part 7 - add assertions to ensure Ensure{Audio,Video}DecodeTaskQueued is never called by DecodingFirstFrameState. r=kaku
You need to log in before you can comment on or make changes to this bug.