There is a very strange #ifdef situation in ns4XPlugin.cpp which makes it very difficult for me to create an OS/2 specific section as the other platforms have. In particular http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/ns4xPlu gin.cpp#396 should be XP_OS2 I need the fix in this bug, so I can subsequently add in my OS/2 specific fix for plugins.
Created attachment 75400 [details] [diff] [review] Refactor #ifdefs This patch is essentially adding an XP_OS2 section and an XP_WIN section whereas before some parts of code were shared and some weren't.
Comment on attachment 75400 [details] [diff] [review] Refactor #ifdefs do you relay want to leave this comment? >+#ifdef XP_OS2 > // XXX this probably should be factored out and > // just use trailing XP_WIN. r=serge
Attachment #75400 - Flags: review+
Comment on attachment 75400 [details] [diff] [review] Refactor #ifdefs sr=beard
Attachment #75400 - Flags: superreview+
Comment on attachment 75400 [details] [diff] [review] Refactor #ifdefs a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75400 - Flags: approval+
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
verified this is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.