Status

()

--
major
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: mkaply, Assigned: rubydoo123)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
There is a very strange #ifdef situation in ns4XPlugin.cpp which makes 
it very difficult for me to create an OS/2 specific section as the 
other platforms have.

In particular

http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/ns4xPlu
gin.cpp#396

should be XP_OS2

I need the fix in this bug, so I can subsequently add in my OS/2 
specific fix for plugins.
(Reporter)

Comment 1

17 years ago
Created attachment 75400 [details] [diff] [review]
Refactor #ifdefs

This patch is essentially adding an XP_OS2 section and an XP_WIN section
whereas before some parts of code were shared and some weren't.

Comment 2

17 years ago
Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

do you relay want to leave this comment?
>+#ifdef XP_OS2
>   // XXX this probably should be factored out and
>   //      just use trailing XP_WIN.

r=serge
Attachment #75400 - Flags: review+

Comment 3

17 years ago
Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

sr=beard
Attachment #75400 - Flags: superreview+

Comment 4

17 years ago
Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75400 - Flags: approval+
(Reporter)

Comment 5

17 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

17 years ago
verified this is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.