1326018 - Crash in java.lang.NullPointerException: Attempt to invoke interface method ''int android.database.Cursor.getColumnIndexOrThrow(java.lang.String)'' on a null object reference at org.mozilla.gecko.activitystream.Utils.highlightSource(Utils.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

This bug was filed from the Socorro interface and is 
report bp-8b41b6ea-6592-4cba-a916-889552161227.
=============================================================

#2 crash for 20161226030205 build.

There are other org.mozilla.gecko.activitystream.Utils.highlightSource exceptions but I'm not sure if they are related.

https://crash-stats.mozilla.com/signature/?build_id=20161226030205&product=FennecAndroid&release_channel=nightly&platform=Android&signature=java.lang.NullPointerException%3A%20Attempt%20to%20invoke%20interface%20method%20%27%27int%20android.database.Cursor.getColumnIndexOrThrow%28java.lang.String%29%27%27%20on%20a%20null%20object%20reference%20at%20org.mozilla.gecko.activitystream.Utils.highlightSource%28Utils.java%29&date=%3E%3D2016-12-26T00%3A00%3A00.000Z&date=%3C2016-12-28T09%3A03%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_sort=-date&page=1#reports

https://crash-stats.mozilla.com/signature/?build_id=20161226030205&product=FennecAndroid&release_channel=nightly&_sort=-date&platform=Android&signature=java.lang.NullPointerException%3A%20at%20org.mozilla.gecko.activitystream.Utils.highlightSource%28Utils.java%29&date=%3E%3D2016-12-26T00%3A00%3A00.000Z&date=%3C2016-12-28T09%3A03%3A00.000Z

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

@Grisha: This looks like a regression from bug 1319245?

Comment 2

[:Grisha Kruglov]

Sure looks like it!

Comment 3

[:Grisha Kruglov]

highlightsCursor object reference disappears underneath us while we're working through handling a highlight item click. One likely cause might be a race between BrowserApp's hideHomePager (which calls unloads home screen to clear resources, setting our cursor to null) and StreamRecyclerAdapter's onItemClicked (which is building up telemetry data using the cursor).

Comment 4

[:Grisha Kruglov]

Attachment: Bug 1326018 - Process telemetry for highlight click before url open action

Review commit: https://reviewboard.mozilla.org/r/103392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103392/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8825200 [details]
Bug 1326018 - Process telemetry for highlight click before url open action

https://reviewboard.mozilla.org/r/103392/#review104106

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478ee1543c0d
Process telemetry for highlight click before url open action r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/478ee1543c0d