1326043 - don't set "create an issue" when replying to review comments

Status: RESOLVED FIXED

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I've been stopped from autolanding for a contributor twice now, because they reply to a review comment of mine and do not uncheck the "create an issue" checkbox.  This is using the inline, popup reply button -- not the reply button on the page that shows review comments without source code.

Once they open an issue, I can't autoland until that issue is closed, and only the creator can close the issue.

Comment 1

[David Walsh :davidwalsh]

Attachment: MozReview: Don't open issues by default whe comment is a reply. (Bug 1326043)

Review commit: https://reviewboard.mozilla.org/r/102966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102966/

Comment 2

[Māris Fogels [:mars] (please needinfo)]

Comment on attachment 8824484 [details]
MozReview: Don't open issues by default whe comment is a reply. (Bug 1326043)

https://reviewboard.mozilla.org/r/102966/#review103558

::: reviewboard/reviewboard/static/rb/js/views/commentDialogView_mozreview.js:641
(Diff revision 1)
>                  reviewRequest: reviewRequestEditor.get('reviewRequest'),
>                  reviewRequestEditor: reviewRequestEditor,
>                  publishedComments: options.publishedComments || undefined,
>                  publishedCommentsType: options.publishedCommentsType ||
> -                                       undefined
> +                                       undefined,
> +                isReply: options.publishedComments.length > 0

This code relies on `options.publishedComments` being an array, so that the call to `publishedComments.length` can be made.  It would blow up if `options.publishedComments` is any other type.

Looking at the truth-test on line 638 above, I'm not sure if we can guarantee that `options.publishedComments` is an array every time.  This new code might need an extra safety check on the type of `options.publishedComments`.

Comment 3

[David Walsh :davidwalsh]

Comment on attachment 8824484 [details]
MozReview: Don't open issues by default whe comment is a reply. (Bug 1326043)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102966/diff/1-2/

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8824484 [details]
MozReview: Don't open issues by default whe comment is a reply. (Bug 1326043)

https://reviewboard.mozilla.org/r/102966/#review105012

Mars: Updated your nit.  When approved, please ping smacleod or glob to land.

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8824484 [details]
MozReview: Don't open issues by default whe comment is a reply. (Bug 1326043)

https://reviewboard.mozilla.org/r/102966/#review106332

Rubber stamping in order to land.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/webtools/reviewboard/rev/6a630d498278
MozReview: Don't open issues by default whe comment is a reply. r=mars,mcote