1326074 - Make destructive buttons more visible

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[Rail Aliiev [:rail]]

I almost scheduled a rule deletion today because I didn't read the whole label. :)

It'd be great to group and make the destructive buttons (Delete, Schedule for Deletion) more visible (red?).

Comment 1

[Thomas Greco]

hey! I would be willing to help out on this. i'm trying to find the right information that could lead me to just how I could accomplish this, so any info would be helpful :) 

Thanks!

Comment 2

[Rail Aliiev [:rail]]

redirecting to bhearsum

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Thomas Greco from comment #1)
> hey! I would be willing to help out on this. i'm trying to find the right
> information that could lead me to just how I could accomplish this, so any
> info would be helpful :) 
> 
> Thanks!

Hi Thomas, thanks for your interest! Your best first step is to make sure you can run the development environment. You'll need Docker and Docker Compose installed, and there's instructions for running the dev environment here: https://github.com/mozilla/balrog

If that's working, head over to http://localhost:8080/rules. You should see some buttons for "Schedule an Update" and "Schedule a Delete" - these are the buttons that Rail is referring to in comment #0. Your goal is to turn them different colours. Let's make the "Schedule a Delete" button red, and "Schedule an Update" yellow. We also recently added these buttons to http://localhost:8080/releases - so please do the same there.

The code you will most likely need to touch is in https://github.com/mozilla/balrog/blob/master/ui/app/templates/rules.html and https://github.com/mozilla/balrog/blob/master/ui/app/templates/releases.html.

I know this a lot to take in, so don't be afraid to ask questions here or on IRC (irc://irc.mozilla.org/#balrog).

Comment 4

[Thomas Greco]

(In reply to Ben Hearsum (:bhearsum) from comment #3)
> (In reply to Thomas Greco from comment #1)
> > hey! I would be willing to help out on this. i'm trying to find the right
> > information that could lead me to just how I could accomplish this, so any
> > info would be helpful :) 
> > 
> > Thanks!
> 
> Hi Thomas, thanks for your interest! Your best first step is to make sure
> you can run the development environment. You'll need Docker and Docker
> Compose installed, and there's instructions for running the dev environment
> here: https://github.com/mozilla/balrog
> 
> If that's working, head over to http://localhost:8080/rules. You should see
> some buttons for "Schedule an Update" and "Schedule a Delete" - these are
> the buttons that Rail is referring to in comment #0. Your goal is to turn
> them different colours. Let's make the "Schedule a Delete" button red, and
> "Schedule an Update" yellow. We also recently added these buttons to
> http://localhost:8080/releases - so please do the same there.
> 
> The code you will most likely need to touch is in
> https://github.com/mozilla/balrog/blob/master/ui/app/templates/rules.html
> and
> https://github.com/mozilla/balrog/blob/master/ui/app/templates/releases.html.
> 
> I know this a lot to take in, so don't be afraid to ask questions here or on
> IRC (irc://irc.mozilla.org/#balrog).

Awesome! I ran `docker-compose` and it's allowed me to access localhost:8080 on my machine. It seems like there's some type of error exception right now as it's printing that to my console but nonetheless I have it running :) I'm not super well-versed in docker but this is a great reason to really get my feet wet. Also, thank you for letting me know where that code lies - super helpful!

I'll let you know how the rest goes. Let me know if you have any questions.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/0be79bb7637d617fbacf79e06f5afc156e729944
bug 1326074  - Make destrucive buttons more visible (#224). r=bhearsum

Comment 6

[[e-mail] (:bhearsum)]

In production, thanks Thomas!