1326087 - Container properties: accesskeys don't work

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Nightly and Aurora (53.0a1 and 52.0a2) on Windows 8.1 64-bit

The accesskeys in the preferences of a container don't work

Steps to reproduce:
1. Open about:config by typing in the location bar and press Enter.
2. Confirm the warning.
3. Search for privacy.userContext.ui.enabled and set it to true if it hasn't yet that value.
4. Search for privacy.userContext.enabled and set it to true if it hasn't yet that value.
5. Open the Preferences/Options, go to Privacy > Container Tabs (at the bottom) > Settings.
6. Click on the "Preferences" button of a container type.
7. Hold Alt + Shift + C to access the Color setting.
Actual result:
Currently selected color doesn't get focus (left and right keys don't work, black circle)
Expected:
Currently selected color doesn't get focus (left and right keys change color, blue circle)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1326087 - Make accesskeys in container properties dialog work.

Review commit: https://reviewboard.mozilla.org/r/101206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101206/

Comment 2

[Jonathan Kingston [:jkt] he/him]

The STR lists 'c' for the access key. The current access key for 'Color' is 'o'. However the patch fixes making this work. Thank you!

Comment 3

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8822235 [details]
Bug 1326087 - Make accesskeys in container properties dialog work.

https://reviewboard.mozilla.org/r/101206/#review101822

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7df3042c2453
Make accesskeys in container properties dialog work. r=jkt

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7df3042c2453

Comment 6

[Surentharan]

[bugday-20170104] Bug verified

Comment 7

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to verify this issue on Firefox 53.0a1 (2017-01-04), under Ubuntu 14.04x64 and under Windows 10x64.

On Mac OS X 10.12.2, the issue is still reproducible. The focus remain on the text box even if using the accesskeys, or the tab key. Also if clicking on a specific color it does not move the focus from the text box. 

Jonathan, should I reopen this bug, or is it better to open a new one for this issue.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

On Mac, the accesskey should be Control (Cmd?) + Alt + key, see https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey No idea about the other issues, hope someone with a Mac can shine some light on this.

Comment 9

[Nirmal GL]

[bugday-20170104] Bug verified successfully

Comment 10

[Kazi Nuzhat Tasnem]

I have reproduced this bug with Firefox nightly 53.0a1 (build id:20161228030213)on
windows 7(64 bit)

I have verified as fixed this bug with Firefox nightly 53.0a1(build id:20170110075905)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170111]

Comment 11

[Md. Majedul islam]

I have reproduced this bug with Firefox nightly 53.0a1(Build ID 20161228030213) on Ubuntu 16.10, 64 Bit !

This bug's fix is verified with latest Nightly.

Build ID   :  20170111030235
User Agent :  Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170111]

Comment 12

[Kamil Jozwiak [:kjozwiak]]

> On Mac OS X 10.12.2, the issue is still reproducible. The focus remain on
> the text box even if using the accesskeys, or the tab key.

I'm seeing the same thing... It looks like macOS inserts accent characters into the "Name" field rather than using the shortcut. The only time the shortcuts seem to work is when the "Name" field isn't selected.

Created bug#1333214.

> Also if clicking on a specific color it does not move the focus from
> the text box.

I couldn't reproduce this.. I went through bug#1326058 on several different platforms and colour/icon selection worked without any problems. Mihai, were you able to reproduce this on a consistent basis when you were testing this issue? Or did it just occur the one time?

Comment 13

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: 1326087.mov

> Also if clicking on a specific color it does not move the focus from
> the text box.


>I couldn't reproduce this.. I went through bug#1326058 on several different >platforms and colour/icon selection worked without any problems. Mihai, were you >able to reproduce this on a consistent basis when you were testing this issue? >Or did it just occur the one time?

Hi Kamil,

The issue is still reproducible on Latest Nightly. I've attached a video in order to see exactly what's happening on my side.

The test was performed under Mac OS X 10.12.1.

Note that on Ubuntu and Windows OSs the issue is not reproducible.

Please let me know if you need any other information related to this issue and also, sorry for the delay.

Comment 14

[Kamil Jozwiak [:kjozwiak]]

Thanks Mihai! I'm seeing this under macOS as well now.. I'm pretty this is the main cause of bug#1333214. Because the "Name" field is always being selected, using the shortcuts under macOS inserts accent characters into the Name field rather selecting the appropriate category.