1326126 - Run tests in safe mode

Status: NEW

(Testing :: General, defect, P3)

Description

[(no longer active)]

See the discussion in <https://mail.mozilla.org/pipermail/firefox-dev/2016-December/004902.html>.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this might be interesting to schedule.  Can we push to try with preference to verify the tests work?  I suspect there might be other oddities we run into.

Comment 2

[(no longer active)]

(In reply to Joel Maher ( :jmaher) from comment #1)
> this might be interesting to schedule.  Can we push to try with preference
> to verify the tests work?  I suspect there might be other oddities we run
> into.

Sure, just initialize gSafeMode to true here <http://searchfox.org/mozilla-central/rev/51aa673e28802fe6ea89f4793721fc55334a6ac8/toolkit/xre/nsAppRunner.cpp#639> and push to try.  Note that doing that will "fix" bug 1326245 which is what you want for any meaningful testing.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

doing this, I ended up with a lot of oranges:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d2f5d035dd46258436c39d3f54bb796007a5ae5

[task 2016-12-29T19:17:39.671715Z] 19:17:39     INFO - 1483039059667	addons.xpi	WARN	Exception running bootstrap method install on [e-mail]: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/worker/workspace/build/application/firefox/browser/features/[e-mail]!/bootstrap.js :: this.install :: line 38"  data: no] Stack trace: this.install()@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/worker/workspace/build/application/firefox/browser/features/[e-mail]!/bootstrap.js:38 < callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4986 < processFileChanges()@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:2097 < checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3827 < startup()@resource://gre/modules/addons/XPIProvider.jsm:2831 < callProvider()@resource://gre/modules/AddonManager.jsm:264 < _startProvider()@resource://gre/modules/AddonManager.jsm:771 < startup()@resource://gre/modules/AddonManager.jsm:957 < startup()@resource://gre/modules/AddonManager.jsm:2923 < observe()@resource://gre/components/addonManager.js:65
[task 2016-12-29T19:19:37.855300Z] 19:19:37     INFO -  Traceback (most recent call last):
[task 2016-12-29T19:19:37.857162Z] 19:19:37     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2425, in doTests
[task 2016-12-29T19:19:37.857224Z] 19:19:37     INFO -      marionette_args=marionette_args,
[task 2016-12-29T19:19:37.857919Z] 19:19:37     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2008, in runApp
[task 2016-12-29T19:19:37.857987Z] 19:19:37     INFO -      self.marionette.start_session(timeout=port_timeout)
[task 2016-12-29T19:19:37.858766Z] 19:19:37     INFO -    File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/decorators.py", line 28, in _
[task 2016-12-29T19:19:37.858828Z] 19:19:37     INFO -      m._handle_socket_failure()
[task 2016-12-29T19:19:37.859557Z] 19:19:37     INFO -    File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/decorators.py", line 23, in _
[task 2016-12-29T19:19:37.859619Z] 19:19:37     INFO -      return func(*args, **kwargs)
[task 2016-12-29T19:19:37.860381Z] 19:19:37     INFO -    File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1280, in start_session
[task 2016-12-29T19:19:37.860450Z] 19:19:37     INFO -      self.protocol, _ = self.client.connect()
[task 2016-12-29T19:19:37.861173Z] 19:19:37     INFO -    File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/transport.py", line 223, in connect
[task 2016-12-29T19:19:37.861239Z] 19:19:37     INFO -      self.sock.connect((self.addr, self.port))
[task 2016-12-29T19:19:37.862029Z] 19:19:37     INFO -    File "/usr/lib/python2.7/socket.py", line 224, in meth
[task 2016-12-29T19:19:37.864655Z] 19:19:37     INFO -      return getattr(self._sock,name)(*args)
[task 2016-12-29T19:19:37.864734Z] 19:19:37     INFO -  error: [Errno 111] Connection refused
[task 2016-12-29T19:19:37.867659Z] 19:19:37    ERROR - Automation Error: Received unexpected exception while running application
[task 2016-12-29T19:19:37.867707Z] 19:19:37    ERROR - 
[task 2016-12-29T19:19:37.867748Z] 19:19:37     INFO - Stopping web server


it looks as though we are timing out and terminating the web server after we timeout.


some of the web-platform-tests and xpcshell tests are running ok though.  I suspect we would need to do more work to get our addons we use for mochitest*/reftest* harnesses to work in this mode.

Comment 4

[Andreas Tolfsen ❲:ato❳]

This error usually happens when the Marionette server isn’t started (incorrect command-line flags? prefs?) or the client tries to connect on the wrong port.  A simple way to test that is by looking if Firefox binds to port 2828 after passing the -marionette flag with gSafeMode set to true.

I see this AddonManager exception on central without changing gSafeMode, so I don’t think this is anything to worry about.

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Joel Maher ( :jmaher) from comment #3)
> [task 2016-12-29T19:17:39.671715Z] 19:17:39     INFO - 1483039059667
> addons.xpi	WARN	Exception running bootstrap method install on
> [e-mail]: [Exception... "Component returned failure
> code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]" 
> nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
> resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///home/worker/workspace/build/application/firefox/browser/features/
> [e-mail]!/bootstrap.js :: this.install :: line
> 38"  data: no] Stack trace:
> this.install()@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///home/worker/workspace/build/application/firefox/browser/features/
> [e-mail]!/bootstrap.js:38 <
> callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4986 <
> processFileChanges()@resource://gre/modules/addons/XPIProvider.jsm ->
> resource://gre/modules/addons/XPIProviderUtils.js:2097 <
> checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3827 <
> startup()@resource://gre/modules/addons/XPIProvider.jsm:2831 <
> callProvider()@resource://gre/modules/AddonManager.jsm:264 <
> _startProvider()@resource://gre/modules/AddonManager.jsm:771 <
> startup()@resource://gre/modules/AddonManager.jsm:957 <
> startup()@resource://gre/modules/AddonManager.jsm:2923 <
> observe()@resource://gre/components/addonManager.js:65


This is harmless and should be fixed by bug 1325797 FWIW :)