Closed Bug 1326179 Opened 5 years ago Closed 5 years ago

wasm: Disable parallel compilation on machines with 1 core

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file)

disable-parallel-compilation.patch
1.32 KB, patch
luke
: review+
Details | Diff | Splinter Review 
As discussed per email, --no-threads is faster than --thread-count=1: on my machine, compiling AngryBots with the baseline compiler, --no-threads is ~465ms and --thread-count=1 is ~485ms. Still a win, though (it might be more remarkable on mobiles). This patch disables parallel compilation on machines with 1 cpu.
Attachment #8822383 - Flags: review?(luke)
Comment on attachment 8822383 [details] [diff] [review]
disable-parallel-compilation.patch

Review of attachment 8822383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8822383 - Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb05b1d381c
wasm: Disable parallel compilation on machines with 1 CPU; r=luke
https://hg.mozilla.org/mozilla-central/rev/adb05b1d381c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.