Closed
Bug 1326179
Opened 8 years ago
Closed 8 years ago
wasm: Disable parallel compilation on machines with 1 core
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
As discussed per email, --no-threads is faster than --thread-count=1: on my machine, compiling AngryBots with the baseline compiler, --no-threads is ~465ms and --thread-count=1 is ~485ms. Still a win, though (it might be more remarkable on mobiles). This patch disables parallel compilation on machines with 1 cpu.
Attachment #8822383 -
Flags: review?(luke)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8822383 [details] [diff] [review]
disable-parallel-compilation.patch
Review of attachment 8822383 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8822383 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb05b1d381c
wasm: Disable parallel compilation on machines with 1 CPU; r=luke
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•