1326195 - [sidebars] "Get more sidebars" is not working

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Philip Chee]

Get more sidebars opens a blank browser window instead of
http://dmoz.org/Netscape/Sidebar/

1. F9 open sidebar
2. Click on Tabs
3. Click on Sidebar Directory...

1. F9 open sidebar
2. Click on Tabs
3. Click on Customize Sidebar
4. Click on Find More Tabs...

Expected Results:

A new browser window opens with http://dmoz.org/Netscape/Sidebar/

Actual Results:

A new browser window opens with [blank]

Comment 1

[Philip Chee]

Attachment: Patch v1.0 import Services.jsm explicitly before using.

> -pref("sidebar.customize.directory.url", "http://dmoz.org/Netscape/Sidebar/");
> -pref("sidebar.customize.more_panels.url", "http://dmoz.org/Netscape/Sidebar/");
> +pref("sidebar.customize.directory.url", "https://edmullen.net/mozilla/moz_sidebar.php");
> +pref("sidebar.customize.more_panels.url", "https://edmullen.net/mozilla/moz_sidebar.php");

"http://dmoz.org/Netscape/Sidebar/" is gone. Temporarily parking it at "https://edmullen.net/mozilla/moz_sidebar.php"
We should create a resource page at seamonkey-project.org for this really.

Comment 2

[Rainer Bielefeld]

This one is more or less the successor of "Bug 1292481 - "Sidebar directory" opens Browser default Start Page instead of sidebar panels repository", may be Bug 1292481 should be marked as DUP of this one, because we here already have some progress.

Comment 3

[Ian Neal]

Comment on attachment 8822430 [details] [diff] [review]
Patch v1.0 import Services.jsm explicitly before using.

>+++ b/suite/browser/browser-prefs.js
>+pref("sidebar.customize.directory.url", "https://edmullen.net/mozilla/moz_sidebar.php");
>+pref("sidebar.customize.more_panels.url", "https://edmullen.net/mozilla/moz_sidebar.php");
Yes, would be better hosted on seamonkey-project.org

>+++ b/suite/common/sidebar/customize.js

> function BrowseMorePanels()
> {
>   var url = '';
>   var browser_url = "chrome://navigator/content/navigator.xul";
>   var locale;
>   try {
>     url = Services.prefs.getCharPref("sidebar.customize.more_panels.url");
>     var temp = Services.prefs.getCharPref("browser.chromeURL");
>-    if (temp) browser_url = temp;
>+    if (temp)
>+      browser_url = temp;
>   } catch(ex) {
>     debug("Unable to get prefs: "+ex);
>   }
>   window.openDialog(browser_url, "_blank", "chrome,all,dialog=no", url);
Can we not use utilityOverlay.js' getBrowserURL() to simplify this and sidebarOverlay.js?

r/a=me with those addressed.

Comment 4

[Philip Chee]

> Yes, would be better hosted on seamonkey-project.org
Out of scope for this bug?

> Can we not use utilityOverlay.js' getBrowserURL() to simplify this and
> sidebarOverlay.js?
Overkill in my opinion. Also, out of scope for this bug. In my opinion the whole sidebar code needs a complete rewrite.

> r/a=me with those addressed.

Comment 5

[Philip Chee]

Pushed comm-central changeset 22cb22616d04
http://hg.mozilla.org/comm-central/rev/22cb22616d04098b038d67859364cc8f63b302a8
on Mon, 02 Jan 2017 23:45:20 +0800

Comment 6

[Philip Chee]

Comment on attachment 8822430 [details] [diff] [review]
Patch v1.0 import Services.jsm explicitly before using.

[Approval Request Comment]
Regression caused by (bug #): Bug 735333 and Bug 667662.
User impact if declined:  "Get more sidebars" is not working.
Testing completed (on m-c, etc.): mozilla-central.
Risk to taking this patch (and alternatives if risky): none. fix broken code.
String changes made by this patch: none.

Comment 7

[Philip Chee]

https://hg.mozilla.org/releases/comm-aurora/rev/24d9c2b8521f5980653e28f7ccd409d87ffe6b43
https://hg.mozilla.org/releases/comm-beta/rev/de0530fcc7c8b8e22404ee33c5538b6d5a638733