1326235 - The awesomebar dances up and down with each character typed when the text entered looks like a URL

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: regression from change in awesomebar behavior shipping in 52

STR:
Click on the location bar
Type "abc"
Enable Search Suggestions
Continue typing, the location bar should now read "abc.def"
As each letter is added after the period, the awesomebar will shift up and down

Note that the awesomebar doesn't get the shakes when backspace is used.

Tested on Windows 10 Nightly 53.0a1 (2016-12-29) (64-bit) and confirmed that it is a regression from bug 1256074 via mozregression.

Comment 1

[Marco Bonardo [:mak]]

I cannot reproduce just by typing "abc.def". I don't see any jumping at all, I tried typing both slow and fast.
Is it mandatory to enable search suggestions at that time?

Comment 2

[Marco Bonardo [:mak]]

After discussing on IRC, we figured this is a DPI problem, due to bug 1325816.
The only reason it happens after bug 1256074, is that such bug added a second entry to the popup.

Comment 3

[Marco Bonardo [:mak]]

Note, I couldn't reproduce cause I use 225% DPI setting, Jared uses 200%.

Comment 4

[Marco Bonardo [:mak]]

Remove tracking cause this is caused by one-off buttons that are Nightly only so far.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Marco Bonardo [::mak] from comment #3)
> Note, I couldn't reproduce cause I use 225% DPI setting, Jared uses 200%.

Correction (my fault), I was using 150% DPI settings.

Comment 6

[Itiel]

See attached GIF file demostrating the issue (though, I'm not 100% sure this is what Jared meant by "awesomebar dances").

Comment 7

[Itiel]

Attachment: Demonstration

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to ItielMaN from comment #6)
> See attached GIF file demostrating the issue (though, I'm not 100% sure this
> is what Jared meant by "awesomebar dances").

Yes, this is what I meant.

Comment 9

[Marco Bonardo [:mak]]

This should have been fixed by the dependency, Jared, could you please check on latest nightly?

Comment 10

[Itiel]

(In reply to Marco Bonardo [::mak] from comment #9)
> This should have been fixed by the dependency, Jared, could you please check
> on latest nightly?

Yep, that seems to be fixed as well on latest Nightly.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Yes, I can confirm that this is fixed for me now. 

I went to Display Settings and changed to 150% and was able to reproduce this bug with the latest Nightly. After signing out and signing back in, I am no longer able to reproduce the bug. Most display scaling requires signing out and back in, so this requirement is not unusual.