Closed Bug 1326236 Opened 4 years ago Closed 4 years ago

Intermittent test_direct_update.py TestDirectUpdate.test_update, test_fallback_update.py TestFallbackUpdate.test_update | ValueError: invalid literal for int() with base 10: ''

Categories

(Testing :: Firefox UI Tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox51 unaffected, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

 05:50:15     INFO - Traceback (most recent call last):
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 166, in run
 05:50:15     INFO -     testMethod()
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/tests/firefox-ui/tests/update/fallback/test_fallback_update.py", line 22, in test_update
 05:50:15     INFO -     self.check_update_applied()
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_ui_harness/testcases.py", line 138, in check_update_applied
 05:50:15     INFO -     update_available = self.check_for_updates(about_window)
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_ui_harness/testcases.py", line 119, in check_for_updates
 05:50:15     INFO -     self.assertEqual(about_window.deck.selected_panel,
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/ui/about_window/deck.py", line 125, in selected_panel
 05:50:15     INFO -     return self.panels[self.selected_index]
 05:50:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/ui/about_window/deck.py", line 117, in selected_index
05:50:15 INFO - return int(self.element.get_attribute('selectedIndex'))

So it's a regression caused by my patch on bug 1277090. Not sure why I haven't seen this locally because I explicitly tested updates from older builds without this change.
Assignee: nobody → hskupin
Blocks: 1277090
Status: NEW → ASSIGNED
Keywords: regression
Summary: Intermittent test_direct_update.py TestDirectUpdate.test_update | ValueError: invalid literal for int() with base 10: '' → Intermittent test_direct_update.py TestDirectUpdate.test_update, test_fallback_update.py TestFallbackUpdate.test_update | ValueError: invalid literal for int() with base 10: ''
Ok, so the problem happens in the updated build. That makes it clear why I was not able to see it with a local update test run. I will have to see why our Puppeteer unit tests do not cover this.
Comment on attachment 8822490 [details]
Bug 1326236 - Use get_property() to retrieve the selectedIndex of decks and wizards.

https://reviewboard.mozilla.org/r/101402/#review101924

Could you add the following to the commit message:
* What regression this fixes (the bug that introduced it).
* What is broken about using get_attribute here
Attachment #8822490 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25505bf601f6
Use get_property() to retrieve the selectedIndex of decks and wizards. r=maja_zf
Problem here is that the test for the selected_panel is too specific. Some builds will have updates available whereby others not. I should change the assertion to check for the general panel type.
Flags: needinfo?(hskupin)
Comment on attachment 8822490 [details]
Bug 1326236 - Use get_property() to retrieve the selectedIndex of decks and wizards.

https://reviewboard.mozilla.org/r/101400/#review101942

The change from checking for a specific panel to an instance check for the class Panel solves it, and that is perfectly enough for the Puppeteer unit test. The try run is green now.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/121fd60184a7
Use get_property() to retrieve the selectedIndex of decks and wizards. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/121fd60184a7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
When uplifting this test-only patch please make sure to do it together with the patches on bug 1277090. Thanks.
Whiteboard: [checkin-needed-aurora][uplift together with patch on bug 1277090]
https://hg.mozilla.org/releases/mozilla-aurora/rev/286cc5f7a92d
Whiteboard: [checkin-needed-aurora][uplift together with patch on bug 1277090]
You need to log in before you can comment on or make changes to this bug.