Closed Bug 1326248 Opened 7 years ago Closed 7 years ago

No inverted icons in Event dialog with dark toolbars

Categories

(Calendar :: Dialogs, defect)

Lightning 5.4
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: pmorris)

References

Details

(Keywords: regression)

Attachments

(1 file)

It seems since Bug 1277972 the "brighttext" detection works no more in Event dialog.

Tested on Linux with Ubuntu Ambiance theme where the toolbars are dark. With TB 45.6.0 this is still working.
Paul, could you look at this as it is a regression from bug 1277972? This would annoy a lot of Ubuntu users with the Ambiance theme.
Sure, I can take a look when I get a chance.  I'm on ubuntu so that will help.
Assignee: nobody → paul
Attached patch invertedToolbarIcons.patch — — Splinter Review
It was an in-or-out-of-the-iframe problem.  This patch fixes it.  I wasn't sure about reviewers so I put Fallen with Paenglab on ui-review.
Attachment #8833126 - Flags: ui-review?(richard.marti)
Attachment #8833126 - Flags: review?(philipp)
Comment on attachment 8833126 [details] [diff] [review]
invertedToolbarIcons.patch

Works again in event in a window.

Thank you Paul.
Attachment #8833126 - Flags: ui-review?(richard.marti) → ui-review+
Paenglab, can you please check whether this also an issue in the current beta?
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Version: unspecified → Lightning 5.5
This is an issue on beta and needs uplifting.
Flags: needinfo?(richard.marti)
Thanks. Philipp, can you do the review within the next days so we can uplift this in time for b3?
Version: Lightning 5.5 → Lightning 5.4
Attachment #8833126 - Flags: review?(philipp)
Attachment #8833126 - Flags: review+
Attachment #8833126 - Flags: approval-calendar-beta+
Attachment #8833126 - Flags: approval-calendar-aurora+
Checked-in already because we needed a build run after m-c merge.

https://hg.mozilla.org/comm-central/rev/71895f2bdade1d69039d6c0814213791fe0f9097
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: