Closed
Bug 1326248
Opened 7 years ago
Closed 7 years ago
No inverted icons in Event dialog with dark toolbars
Categories
(Calendar :: Dialogs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
5.4
People
(Reporter: Paenglab, Assigned: pmorris)
References
Details
(Keywords: regression)
Attachments
(1 file)
6.67 KB,
patch
|
Fallen
:
review+
Paenglab
:
ui-review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
It seems since Bug 1277972 the "brighttext" detection works no more in Event dialog. Tested on Linux with Ubuntu Ambiance theme where the toolbars are dark. With TB 45.6.0 this is still working.
Reporter | ||
Comment 1•7 years ago
|
||
Paul, could you look at this as it is a regression from bug 1277972? This would annoy a lot of Ubuntu users with the Ambiance theme.
Assignee | ||
Comment 2•7 years ago
|
||
Sure, I can take a look when I get a chance. I'm on ubuntu so that will help.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 3•7 years ago
|
||
It was an in-or-out-of-the-iframe problem. This patch fixes it. I wasn't sure about reviewers so I put Fallen with Paenglab on ui-review.
Attachment #8833126 -
Flags: ui-review?(richard.marti)
Attachment #8833126 -
Flags: review?(philipp)
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8833126 [details] [diff] [review] invertedToolbarIcons.patch Works again in event in a window. Thank you Paul.
Attachment #8833126 -
Flags: ui-review?(richard.marti) → ui-review+
Comment 5•7 years ago
|
||
Paenglab, can you please check whether this also an issue in the current beta?
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Version: unspecified → Lightning 5.5
Reporter | ||
Comment 6•7 years ago
|
||
This is an issue on beta and needs uplifting.
Flags: needinfo?(richard.marti)
Comment 7•7 years ago
|
||
Thanks. Philipp, can you do the review within the next days so we can uplift this in time for b3?
Version: Lightning 5.5 → Lightning 5.4
Updated•7 years ago
|
Attachment #8833126 -
Flags: review?(philipp)
Attachment #8833126 -
Flags: review+
Attachment #8833126 -
Flags: approval-calendar-beta+
Attachment #8833126 -
Flags: approval-calendar-aurora+
Reporter | ||
Comment 8•7 years ago
|
||
Checked-in already because we needed a build run after m-c merge. https://hg.mozilla.org/comm-central/rev/71895f2bdade1d69039d6c0814213791fe0f9097
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.6
Comment 9•7 years ago
|
||
Aurora (TB 53, Calendar 5.5): https://hg.mozilla.org/releases/comm-aurora/rev/8c13d47b6c8a0ce582da740da51a7d051d6aa669
Target Milestone: 5.6 → 5.5
Comment 10•7 years ago
|
||
Beta (TB 52, Calendar 5.4): https://hg.mozilla.org/releases/comm-beta/rev/57554453cc0a9fed84356632e050666827739a90
Target Milestone: 5.5 → 5.4
You need to log in
before you can comment on or make changes to this bug.
Description
•