Closed Bug 1326291 Opened 4 years ago Closed 4 years ago

[RTL] Align the domain name in the site info panel to the right

Categories

(Firefox for Android :: Theme and Visual Design, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox53 --- affected
firefox54 --- verified

People

(Reporter: itiel_yn8, Assigned: maliu)

References

(Blocks 1 open bug)

Details

(Keywords: rtl)

Attachments

(3 files)

Attached image The panel on a New Tab
To match the site info panel's UI, the domain name (including "Nightly" etc) should be aligned to the right in RTL builds.

See attached screenshots of the panel's current look.
Max - can we have your input here?
Flags: needinfo?(max)
OS: Unspecified → All
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
I think the hostname should align with the favicon in RTL context. I'll take it from here.
Assignee: nobody → max
Flags: needinfo?(max)
Comment on attachment 8833157 [details]
Bug 1326291 - Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL,

https://reviewboard.mozilla.org/r/109384/#review110534
Attachment #8833157 - Flags: review?(s.kaspari) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f90b03778d1b
Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL, r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f90b03778d1b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I can confirm this is fixed on latest Nightly.
Marking 54 as verified from the above comment.
You need to log in before you can comment on or make changes to this bug.