[RTL] Align the domain name in the site info panel to the right

RESOLVED FIXED in Firefox 54

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: ItielMaN, Assigned: maliu)

Tracking

(Blocks: 1 bug, {rtl})

Trunk
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 affected, firefox54 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

8 months ago
Created attachment 8822518 [details]
The panel on a New Tab

To match the site info panel's UI, the domain name (including "Nightly" etc) should be aligned to the right in RTL builds.

See attached screenshots of the panel's current look.
(Reporter)

Comment 1

8 months ago
Created attachment 8822519 [details]
The panel on cdburnerxp.se

Comment 2

7 months ago
Max - can we have your input here?
status-firefox53: --- → affected
Flags: needinfo?(max)
OS: Unspecified → All
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
Blocks: 1319302
(Assignee)

Comment 3

7 months ago
I think the hostname should align with the favicon in RTL context. I'll take it from here.
Assignee: nobody → max
Flags: needinfo?(max)
Comment hidden (mozreview-request)

Comment 5

7 months ago
mozreview-review
Comment on attachment 8833157 [details]
Bug 1326291 - Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL,

https://reviewboard.mozilla.org/r/109384/#review110534
Attachment #8833157 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 6

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f90b03778d1b
Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL, r=sebastian
Keywords: checkin-needed

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f90b03778d1b
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Reporter)

Comment 8

7 months ago
I can confirm this is fixed on latest Nightly.
Marking 54 as verified from the above comment.
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.