Open Bug 1326299 Opened 7 years ago Updated 2 years ago

Fail non-whitelisted tests which break off-main-thread data delivery

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

Tracking Status
firefox53 --- affected

People

(Reporter: kmag, Unassigned)

References

Details

(Whiteboard: [necko-backlog])

Currently, it's quite easy to break off-main-thread data delivery without anyone noticing. Bug 1157561, for instance, broke it for all HTTP requests, any time an extension adds an onStart, onStop, or onError listener. Obviously, there's still not much we can do about legacy extensions breaking this, but we should at least be able to catch the instances where in-tree code does so inadvertently.

The simplest solution I can think of is to emit something like an observer notification in debug builds every time retargeting an HTTP request fails, and have the xpcshell and mochitest harnesses emit a failure whenever it receives that notification, and a whitelist flag hasn't been set.
Assignee: nobody → mcmanus
Whiteboard: [necko-active]
Assignee: mcmanus → nobody
Whiteboard: [necko-active] → [necko-backlog]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.