Closed Bug 1326301 Opened 3 years ago Closed 3 years ago

Use the system zone for SimpleGlobalObject

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

This should make them a bit quicker to finalize.  See bug 1324176 comment 19 and preceding discussion.
Comment on attachment 8822538 [details] [diff] [review]
Put the global allocated by SimpleGlobalObject in the system zone, so we don't create tons of zones when we're converting JSON to dictionaries many times over

Review of attachment 8822538 [details] [diff] [review]:
-----------------------------------------------------------------

Neat.

::: dom/bindings/SimpleGlobalObject.cpp
@@ +109,5 @@
> +    options.creationOptions()
> +           .setInvisibleToDebugger(true)
> +           // Put our SimpleGlobalObjects in the system zone, so we won't create
> +           // lots of zones for what are probably very short-lived
> +           // compartments.  This should help them be gced quicker and take up

Nit: Both of these "gced" should be "GCed".
Attachment #8822538 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50c889c86cb8
Put the global allocated by SimpleGlobalObject in the system zone, so we don't create tons of zones when we're converting JSON to dictionaries many times over.  r=mccr8
https://hg.mozilla.org/mozilla-central/rev/50c889c86cb8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.