1326330 - Some MediaQueue code cleanup

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1326330. Part 1 - remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/101438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101438/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1326330. Part 2 - add assertions and checks.

1. ensure the 'finish' event is notified only once.
2. assert pushing items to a finished queue.

Review commit: https://reviewboard.mozilla.org/r/101440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101440/

Comment 3

[James Cheng[:JamesCheng]]

Comment on attachment 8822580 [details]
Bug 1326330. Part 1 - remove unused functions.

https://reviewboard.mozilla.org/r/101438/#review101962

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8822581 [details]
Bug 1326330. Part 2 - add assertions and checks.

https://reviewboard.mozilla.org/r/101440/#review101964

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27f5d9d78b9d
Part 1 - remove unused functions. r=JamesCheng
https://hg.mozilla.org/integration/autoland/rev/86dde0dace53
Part 2 - add assertions and checks. r=JamesCheng

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27f5d9d78b9d
https://hg.mozilla.org/mozilla-central/rev/86dde0dace53