Closed Bug 1326335 Opened 6 years ago Closed 6 years ago

Ensure MDSM only decode metadata once

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/51aa673e28802fe6ea89f4793721fc55334a6ac8/dom/media/MediaDecoderStateMachine.cpp#1918

We should call mMaster->mInfo.emplace() to ensure mInfo is constructed only once. In other words, we expect OnMetadataRead() is only called once for the entire lifetime of MDSM.
Assignee: nobody → jwwang
Blocks: 1324999
Priority: -- → P3
Attachment #8822583 - Flags: review?(kaku)
Comment on attachment 8822583 [details]
Bug 1326335 - Ensure MDSM only decodes metadata once.

https://reviewboard.mozilla.org/r/101448/#review102402

I could see the improvement of efficiency of this change, but I have no idea about why does this change "ensure MDSM only decodes metadata once"?
Attachment #8822583 - Flags: review?(kaku) → review+
Comment on attachment 8822583 [details]
Bug 1326335 - Ensure MDSM only decodes metadata once.

https://reviewboard.mozilla.org/r/101448/#review102402

If DecodeMetadataState::OnMetadataRead() is called more than once, it will fail the assertion in Maybe<>::emplace().
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45a833acac7c
Ensure MDSM only decodes metadata once. r=kaku
https://hg.mozilla.org/mozilla-central/rev/45a833acac7c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.