Closed
Bug 1326335
Opened 8 years ago
Closed 8 years ago
Ensure MDSM only decode metadata once
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
http://searchfox.org/mozilla-central/rev/51aa673e28802fe6ea89f4793721fc55334a6ac8/dom/media/MediaDecoderStateMachine.cpp#1918
We should call mMaster->mInfo.emplace() to ensure mInfo is constructed only once. In other words, we expect OnMetadataRead() is only called once for the entire lifetime of MDSM.
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8822583 -
Flags: review?(kaku)
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8822583 [details]
Bug 1326335 - Ensure MDSM only decodes metadata once.
https://reviewboard.mozilla.org/r/101448/#review102402
I could see the improvement of efficiency of this change, but I have no idea about why does this change "ensure MDSM only decodes metadata once"?
Attachment #8822583 -
Flags: review?(kaku) → review+
Assignee | ||
Comment 3•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8822583 [details]
Bug 1326335 - Ensure MDSM only decodes metadata once.
https://reviewboard.mozilla.org/r/101448/#review102402
If DecodeMetadataState::OnMetadataRead() is called more than once, it will fail the assertion in Maybe<>::emplace().
Assignee | ||
Comment 4•8 years ago
|
||
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45a833acac7c
Ensure MDSM only decodes metadata once. r=kaku
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•