Closed Bug 1326411 Opened 7 years ago Closed 7 years ago

ResolveLocale shouldn't compute the locale data for each extension key anew

Categories

(Core :: JavaScript: Internationalization API, defect)

Product:
Core
Component:
JavaScript: Internationalization API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox53 --- affected
firefox54 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file, 1 obsolete file)

bug1326411.patch
1.32 KB, patch
anba
: review+
Details | Diff | Splinter Review 
This call [1] should be moved out of the loop.

(Setting bug 1321789 as a blocker, because 1321789 also changes ResolveLocale.)

[1] https://dxr.mozilla.org/mozilla-central/rev/6f63f95e28ffc05c0d2f5ef6cd6e05905fe8ea5a/js/src/builtin/Intl.js#954
Attached patch bug1326411.patch (obsolete) — — Splinter Review 
Requires the patch from bug 1321789.
Attachment #8825062 - Flags: review?(jwalden+bmo)
Attachment #8825062 - Flags: review?(jwalden+bmo) → review+
Attached patch bug1326411.patch — — Splinter Review 
Disentangle the patch from bug 1321789. A new review isn't necessary, because it only changes step number comments, therefore carrying r+ from Waldo.
Attachment #8825062 - Attachment is obsolete: true
Attachment #8837538 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fde41ab81a44
Don't recompute locale data for each Unicode extension key. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fde41ab81a44
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: