1326423 - "netwerk/ipc/NeckoParent.cpp:492:22: error: unused variable 'p' [-Werror=unused-variable]" bustage when Gecko 52 merges to Beta

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Merge day bustage.

This is across the board bustage that's due to hit in less than a month on the next merge day. Looks like bug 1307331 touched this line during the 52 cycle, so starting there.

https://treeherder.mozilla.org/logviewer.html#?job_id=65498919&repo=try

The patch below is what was used to simulate the uplift if you need to test locally or on Try:
https://hg.mozilla.org/try/raw-rev/f13395b7904b742e4a227f9f0e0130b4c215b552

Comment 1

[Marcia Knous [:marcia]]

Tracking 52/53+ to address this bustage before the next merge.

Comment 2

[Carsten Book [:Tomcat]]

talked to baku and he will take a look at this

Comment 3

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Attachment: Bug 1326423 - Fix assertion for optimized build.

Review commit: https://reviewboard.mozilla.org/r/102118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102118/

Comment 4

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

MOZ_ASSERT should be enough in this case.

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8823578 [details]
Bug 1326423 - Fix assertion for optimized build.

https://reviewboard.mozilla.org/r/102118/#review102514

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/558eca1b4460
Fix assertion for optimized build. r=baku

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/558eca1b4460

Comment 8

[Carsten Book [:Tomcat]]

we still need to uplift this to aurora since we see this in uplift simulations for aurora as beta

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 8823578 [details]
Bug 1326423 - Fix assertion for optimized build.

Approval Request Comment
[Feature/Bug causing the regression]: Introduction of MOZ_DIAGNOSTIC_ASSERT
[User impact if declined]: beta does't compile
[Is this code covered by automated tests?]: it's not needed
[List of other uplifts needed for the feature/fix]: 0
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's just a debug variable.
[String changes made/needed]: none

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8823578 [details]
Bug 1326423 - Fix assertion for optimized build.

avoid bustage on next merge day, aurora52+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9545084f13f8