Closed
Bug 1326453
Opened 5 years ago
Closed 5 years ago
Remove @@iterator from module namespace objects, and more namespace object updates
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(5 files)
|
8.02 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
2.16 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
2.32 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
3.72 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
11.31 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
https://github.com/tc39/ecma262/pull/747 - Remove @@iterator from module namespace objects - Change [[Configurable]] of @@toStringTag to false https://github.com/tc39/ecma262/pull/748 - Allow to call [[SetPrototypeOf]] with null
|
Assignee | |
Comment 1•5 years ago
|
||
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8822783 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attachment #8822784 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #8822785 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Attachment #8822786 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Attachment #8822787 -
Flags: review?(jcoppeard)
|
||
Comment 6•5 years ago
|
||
Comment on attachment 8822783 [details] [diff] [review] bug1326453-part1.patch Review of attachment 8822783 [details] [diff] [review]: ----------------------------------------------------------------- Well this was some code I didn't have to write :-)
Attachment #8822783 -
Flags: review?(jcoppeard) → review+
|
|
||
Updated•5 years ago
|
Attachment #8822784 -
Flags: review?(jcoppeard) → review+
|
|
||
Updated•5 years ago
|
Attachment #8822785 -
Flags: review?(jcoppeard) → review+
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 8822786 [details] [diff] [review] bug1326453-part4.patch Review of attachment 8822786 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for adding this and the improved tests.
Attachment #8822786 -
Flags: review?(jcoppeard) → review+
|
|
||
Comment 8•5 years ago
|
||
Comment on attachment 8822787 [details] [diff] [review] bug1326453-part5.patch Review of attachment 8822787 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8822787 -
Flags: review?(jcoppeard) → review+
|
|
||
Comment 9•5 years ago
|
||
Luke, FYI it seems the spec for module namespace objects has recently been updated and there's no longer an @@iterator property (see links in comment 1 for details).
Flags: needinfo?(luke)
|
|
Assignee | |
Comment 11•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d72916cc8abeb91ada66d419cc4735e6517c0775
Keywords: checkin-needed
|
||
Comment 12•5 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aed67a3bb877 Part 1: Remove @@iterator method from module namespace objects per ES2017. r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/3768e0fa8f49 Part 2: Change @@toStringTag for module namespace objects to non-configurable. r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/5459a408763b Part 3: Don't throw a TypeError when SetPrototypeOf for module namespace objects is called with null. r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/873a22cd1fe1 Part 4: Return @@toStringTag in [[OwnPropertyKeys]] trap for module namespace objects. r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/07de2edd9c25 Part 5: Remove no longer used ListIterator implementation. r=jonco
Keywords: checkin-needed
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aed67a3bb877 https://hg.mozilla.org/mozilla-central/rev/3768e0fa8f49 https://hg.mozilla.org/mozilla-central/rev/5459a408763b https://hg.mozilla.org/mozilla-central/rev/873a22cd1fe1 https://hg.mozilla.org/mozilla-central/rev/07de2edd9c25
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•