Closed Bug 1326453 Opened 3 years ago Closed 3 years ago

Remove @@iterator from module namespace objects, and more namespace object updates

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(5 files)

https://github.com/tc39/ecma262/pull/747
- Remove @@iterator from module namespace objects
- Change [[Configurable]] of @@toStringTag to false

https://github.com/tc39/ecma262/pull/748
- Allow to call [[SetPrototypeOf]] with null
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8822783 - Flags: review?(jcoppeard)
Attachment #8822784 - Flags: review?(jcoppeard)
Attachment #8822785 - Flags: review?(jcoppeard)
Attachment #8822786 - Flags: review?(jcoppeard)
Attachment #8822787 - Flags: review?(jcoppeard)
Comment on attachment 8822783 [details] [diff] [review]
bug1326453-part1.patch

Review of attachment 8822783 [details] [diff] [review]:
-----------------------------------------------------------------

Well this was some code I didn't have to write :-)
Attachment #8822783 - Flags: review?(jcoppeard) → review+
Attachment #8822784 - Flags: review?(jcoppeard) → review+
Attachment #8822785 - Flags: review?(jcoppeard) → review+
Comment on attachment 8822786 [details] [diff] [review]
bug1326453-part4.patch

Review of attachment 8822786 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding this and the improved tests.
Attachment #8822786 - Flags: review?(jcoppeard) → review+
Comment on attachment 8822787 [details] [diff] [review]
bug1326453-part5.patch

Review of attachment 8822787 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
Attachment #8822787 - Flags: review?(jcoppeard) → review+
Luke, FYI it seems the spec for module namespace objects has recently been updated and there's no longer an @@iterator property (see links in comment 1 for details).
Flags: needinfo?(luke)
Ah, thanks for pointing that out, sounds good.
Flags: needinfo?(luke)
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aed67a3bb877
Part 1: Remove @@iterator method from module namespace objects per ES2017. r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/3768e0fa8f49
Part 2: Change @@toStringTag for module namespace objects to non-configurable. r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/5459a408763b
Part 3: Don't throw a TypeError when SetPrototypeOf for module namespace objects is called with null. r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/873a22cd1fe1
Part 4: Return @@toStringTag in [[OwnPropertyKeys]] trap for module namespace objects. r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/07de2edd9c25
Part 5: Remove no longer used ListIterator implementation. r=jonco
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.