Closed Bug 1326471 Opened 7 years ago Closed 7 years ago

Ash runs talos-g4 despite being 'enable_talos': False

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: aselagea)

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=ash&filter-searchStr=talos - despite https://hg.mozilla.org/build/buildbot-configs/annotate/985f23bc55f9cd0fc100fd5ace4d7f307342e806/mozilla/project_branches.py#l22 Ash runs talos-g4, which someone must have stuck in in some odd place without checking for whether or not the branch runs talos.
Also Date and Oak, and if Jamun was being used it would too.
Component: General Automation → Buildduty
QA Contact: catlee → bugspam.Callek
Assignee: nobody → aselagea
Alin, I think these are scheduled via taskcluster not buildbot. If you look at 

taskcluster/taskgraph/target_tasks.py

they problem may be here

_target_task('ash_tasks')

 if task.attributes.get('unittest_suite') or task.attributes.get('talos_suite'):
 98             if not task.attributes.get('e10s'):
 99                 return False


the task attributes for the talos in the full task graph 

don't have attribute talos_suite so they still get run

see 

https://public-artifacts.taskcluster.net/Vb6OY7RJTBSiWyQ47UinxA/0/public/full-task-graph.json

for an example

"test-linux64/opt-talos-g4-e10s": {
    "attributes": {
      "build_platform": "linux64",
      "build_type": "opt",
      "e10s": true,
      "kind": "test",
      "run_on_projects": [
        "mozilla-beta",
        "mozilla-aurora",
        "mozilla-central",
        "mozilla-inbound",
        "autoland",
        "graphics",
        "try"
      ],
      "talos_try_name": "g4",
      "test_chunk": "1",
      "test_platform": "linux64",
      "unittest_flavor": "talos",
      "unittest_suite": "talos"
    },
    "dependencies": {
      "build": "build-linux64/opt"
    },
Patch to disable TC talos tests on ash.
Attachment #8830367 - Flags: review?(kmoir)
Tasks diff:

118,126d117
< test-linux64-pgo/opt-talos-chrome-e10s
< test-linux64-pgo/opt-talos-dromaeojs-e10s
< test-linux64-pgo/opt-talos-g1-e10s
< test-linux64-pgo/opt-talos-g2-e10s
< test-linux64-pgo/opt-talos-g3-e10s
< test-linux64-pgo/opt-talos-g4-e10s
< test-linux64-pgo/opt-talos-other-e10s
< test-linux64-pgo/opt-talos-svgr-e10s
< test-linux64-pgo/opt-talos-tp5o-e10s
271,279d261
< test-linux64/opt-talos-chrome-e10s
< test-linux64/opt-talos-dromaeojs-e10s
< test-linux64/opt-talos-g1-e10s
< test-linux64/opt-talos-g2-e10s
< test-linux64/opt-talos-g3-e10s
< test-linux64/opt-talos-g4-e10s
< test-linux64/opt-talos-other-e10s
< test-linux64/opt-talos-svgr-e10s
< test-linux64/opt-talos-tp5o-e10s
Attachment #8830367 - Flags: review?(kmoir) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Pushed by aselagea@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7679c36a2e96
Ash runs talos-g4 despite being 'enable_talos': False, r=kmoir
Jonathan,

Does Ash merge regularly from m-c, or will this patch need to land there?
Flags: needinfo?(jgriffin)
Looks like this merge occurred Jan 29, so we should be good.
Flags: needinfo?(jgriffin)
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: