Closed Bug 1326522 Opened 3 years ago Closed 3 years ago

Union conversions can fail to include the necessary headers

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Unified builds are hiding this, but KeyframeAnimationOptionsBinding.cpp is not including PrimitiveConversions.h even though it has a union that contains a primitive.  That's because we're not checking for primitives in UnionTypes/UnionConversions header stuff.
Attachment #8822818 - Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22124b829bd1
Fix the include situation for unions containing primitives by making UnionTypes/UnionConversions header stuff look more like CGHeaders.  r=peterv
https://hg.mozilla.org/mozilla-central/rev/22124b829bd1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.