Closed Bug 1326522 Opened 7 years ago Closed 7 years ago

Union conversions can fail to include the necessary headers

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Fix the include situation for unions containing primitives by making UnionTypes/UnionConversions header stuff look more like CGHeaders
3.99 KB, patch
peterv
: review+
Details | Diff | Splinter Review 
Unified builds are hiding this, but KeyframeAnimationOptionsBinding.cpp is not including PrimitiveConversions.h even though it has a union that contains a primitive.  That's because we're not checking for primitives in UnionTypes/UnionConversions header stuff.
Attachment #8822818 - Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22124b829bd1
Fix the include situation for unions containing primitives by making UnionTypes/UnionConversions header stuff look more like CGHeaders.  r=peterv
https://hg.mozilla.org/mozilla-central/rev/22124b829bd1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.