1326524 - dom/events/EventListenerManager.cpp:36:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Jan Beich]

On platforms without SPS profiler (e.g. BSDs, Solaris, Darwin/X11 and maybe iOS) some headers under tools/profiler/public/ aren't exported which leads to the following error.

In file included from objdir/dom/events/Unified_cpp_dom_events1.cpp:11:
dom/events/EventListenerManager.cpp:36:10: fatal error: 'ProfilerMarkers.h' file not
      found
#include "ProfilerMarkers.h"
         ^
1 error generated.

Comment 1

[Jan Beich]

Attachment: Bug 1326524 - Unbreak build without SPS profiler after bug 1324941.

Review commit: https://reviewboard.mozilla.org/r/101610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101610/

Comment 2

[Jan Beich]

Comment on attachment 8822820 [details]
Bug 1326524 - Unbreak build without SPS profiler after bug 1324941.

This only uses MOZ_CRASH to avoid having to add extra #ifdef around curly brackets ending "else" branch. I have no clue which style is better.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8822820 [details]
Bug 1326524 - Unbreak build without SPS profiler after bug 1324941.

https://reviewboard.mozilla.org/r/101610/#review102110

Sorry about that.

I think you could also just leave out the #else branch. But it's up to you.

Comment 4

[Jan Beich]

Comment on attachment 8822820 [details]
Bug 1326524 - Unbreak build without SPS profiler after bug 1324941.

https://reviewboard.mozilla.org/r/101610/#review102110

Leaving #else code out would break statu quo from before bug 1324941.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da0b8224b791
Unbreak build without SPS profiler after bug 1324941. r=mstange

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/da0b8224b791