132653 - Missing arrow buttons in embedding dist

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

Users report missing arrows graphics on scrollbars in the embedding dist. This
doesn't affect XP (which renders things natively with the XP theme engine) but
does affect W2K. Looks like a chrome manifest issue. The classic skin has put
the arrow graphics in a subdir which wasn't being picked up in the repackaging.

The patch is below but has yet to be verified.

Comment 1

[Adam Lock]

Attachment: Patch to embed-jar.mn

Patch adds missing chrome dirs.

I wonder if it's possible to disable native rendering on XP so I can verify it
works. Investigating...

Comment 2

[Adam Lock]

Verifying patch brings back the arrows. Jud do you want to review?

I don't know what keywords to add for this since it should go on the trunk and
0.9.9.

Win32 theme behaviour appears to be hardcoded (should be a pref perhaps) so I
had to hack nsNativeTheme.cpp so it wouldn't load to uxtheme.dll in order to
verify this code worked using my XP box.

Comment 3

[Judson Valeski]

adding topembed+ so this can land on the trunk. nominating edt0.9.9 so we can
consider this for 0.9.9 checkin.

Comment 4

[Judson Valeski]

please checkin to the 0.9.9 branch and mark with "fixed0.9.9" upon landing.

Comment 5

[Adam Lock]

Fix checked into 0.9.9 branch. Going through the normal sr/a route for trunk
checkin.

Comment 6

[rpotts (gone)]

Comment on attachment 75453 [details] [diff] [review]
Patch to embed-jar.mn

sr=[e-mail]

Comment 7

[Adam Lock]

Marking FIXED.

Patch is in the trunk and branch

Comment 8

[Michael Dunn]

Brent -- Please verify on branch.