Closed Bug 1326541 Opened 3 years ago Closed 3 years ago

Remove Vista from SeaMonkey supported OS manifest file.

Categories

(SeaMonkey :: OS Integration, defect, minor)

SeaMonkey 2.50 Branch
Unspecified
Windows
defect
Not set
minor

Tracking

(seamonkey2.49esr unaffected, seamonkey2.50 fixed)

RESOLVED FIXED
seamonkey2.50
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.50 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

User Story

https://en.wikipedia.org/wiki/Manifest_file
https://msdn.microsoft.com/en-us/library/aa374191%28v=vs.85%29.aspx
https://blogs.msdn.microsoft.com/chuckw/2013/09/10/manifest-madness/

Attachments

(1 file)

Vista is no longer supported so we can drop telling the OS that SeaMonkey is compatible. Also added comments for each supported Windows OS for better identification in the future

Ports Bug 1325217 to SeaMonkey.
Attachment #8822880 - Flags: review?(iann_bugzilla)
User Story: (updated)
Comment on attachment 8822880 [details] [diff] [review]
1326541-removevistamanifest.patch

>   <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
>     <application>
>+      <!--This Id value indicates the application supports Windows 7 functionality-->
and Server 2008 R2
>+      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
>+      <!--This Id value indicates the application supports Windows 8 functionality-->
and Server 2012
>+      <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
>+      <!--This Id value indicates the application supports Windows 8.1 functionality-->
and Server 2012 R2
>+      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
>+      <!--This Id value indicates the application supports Windows 10 functionality-->
and Server 2016
>       <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>

For completeness can we include the equivalent server versions (as mentioned above) in the comments.

r/a=me with that addressed.
Attachment #8822880 - Flags: review?(iann_bugzilla) → review+
Line length in the file was already longer than 80 chars so I decided to not break the comment up. If not ok I can push a followup formatting fix.

https://hg.mozilla.org/comm-central/rev/fbbe6fd4c87d726ff1e98850e670d1d02855b1b6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
You need to log in before you can comment on or make changes to this bug.