Remove Vista from SeaMonkey supported OS manifest file.

RESOLVED FIXED in seamonkey2.50

Status

SeaMonkey
OS Integration
--
minor
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

SeaMonkey 2.50 Branch
seamonkey2.50
Unspecified
Windows

SeaMonkey Tracking Flags

(seamonkey2.49esr unaffected, seamonkey2.50 fixed)

Details

User Story

https://en.wikipedia.org/wiki/Manifest_file
https://msdn.microsoft.com/en-us/library/aa374191%28v=vs.85%29.aspx
https://blogs.msdn.microsoft.com/chuckw/2013/09/10/manifest-madness/

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
Vista is no longer supported so we can drop telling the OS that SeaMonkey is compatible. Also added comments for each supported Windows OS for better identification in the future

Ports Bug 1325217 to SeaMonkey.
(Assignee)

Comment 1

10 months ago
Created attachment 8822880 [details] [diff] [review]
1326541-removevistamanifest.patch
Attachment #8822880 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

10 months ago
User Story: (updated)

Comment 2

10 months ago
Comment on attachment 8822880 [details] [diff] [review]
1326541-removevistamanifest.patch

>   <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
>     <application>
>+      <!--This Id value indicates the application supports Windows 7 functionality-->
and Server 2008 R2
>+      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
>+      <!--This Id value indicates the application supports Windows 8 functionality-->
and Server 2012
>+      <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
>+      <!--This Id value indicates the application supports Windows 8.1 functionality-->
and Server 2012 R2
>+      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
>+      <!--This Id value indicates the application supports Windows 10 functionality-->
and Server 2016
>       <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>

For completeness can we include the equivalent server versions (as mentioned above) in the comments.

r/a=me with that addressed.
Attachment #8822880 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

10 months ago
Line length in the file was already longer than 80 chars so I decided to not break the comment up. If not ok I can push a followup formatting fix.

https://hg.mozilla.org/comm-central/rev/fbbe6fd4c87d726ff1e98850e670d1d02855b1b6
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-seamonkey2.50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
You need to log in before you can comment on or make changes to this bug.