Closed
Bug 1326542
Opened 7 years ago
Closed 7 years ago
RTL support to about:ServiceWorkers
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: tomer, Assigned: tomer)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
The page about:ServiceWorkers doesn't provide RTL support, even when localized. Steps to reproduce: Enter the about:serviceworkers page on RTL Firefox build. Expected result: Page should be right-aligned.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8822879 -
Flags: review?(ehsan)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8822879 [details] Bug 1326542 - RTL support to about:ServiceWorkers https://reviewboard.mozilla.org/r/101646/#review102292
Attachment #8822879 -
Flags: review?(ehsan) → review+
|
||
Comment 3•7 years ago
|
||
Note, we are migrating to about:debugging and eventually about:serviceworkers will be removed. Does about:debugging support RTL?
Blocks: dt-service-worker
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #3) > Note, we are migrating to about:debugging and eventually > about:serviceworkers will be removed. Does about:debugging support RTL? We've fixed some issues there on bug 1322423.
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/602042c7e7a6 RTL support to about:ServiceWorkers r=Ehsan
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
sorry had to back this out for mochitest bc failures, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66587710&repo=autoland&lineNumber=2224
Flags: needinfo?(tomer.moz.bugs)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96071b9ea305 Backed out changeset 602042c7e7a6 for mochitest browser chrome failures
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•7 years ago
|
||
(In reply to Pulsebot from comment #7) > Backout by ihsiao@mozilla.com Issue has been resolved.
Flags: needinfo?(tomer.moz.bugs)
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d23691fd519a RTL support to about:ServiceWorkers r=Ehsan
Keywords: checkin-needed
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d23691fd519a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•