1326546 - Fix icon for about:sync-tabs on Firefox RTL

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Tomer Cohen :tomer]

The icon in about:sync-tabs appears behind the search box on Firefox RTL builds. 

The fix I suggest is to change tweak the background-position-x to 100% on the headers class for RTL builds.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1326546 - Fix icon for about:sync-tabs on Firefox RTL

Review commit: https://reviewboard.mozilla.org/r/101662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101662/

Comment 2

[Tomer Cohen :tomer]

Comment on attachment 8822887 [details]
Bug 1326546 - Fix icon for about:sync-tabs on Firefox RTL

https://reviewboard.mozilla.org/r/101662/#review102116

Since these three files are identical (I've compared checksums), is there a reason why not merge them into a shared stylesheet? Should I file another bug and fix it as well?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8822887 [details]
Bug 1326546 - Fix icon for about:sync-tabs on Firefox RTL

https://reviewboard.mozilla.org/r/101662/#review102156

I don't have any problem with this, but note that about:sync-tabs is deprecated and will soon be removed - the new UI is available from the "hamburger" menu's "Sync Tabs" entry and/or a "Synced Tabs" sidebar. Thus, I wouldn't bother with another bug to consolidate these style sheets.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e969d31a60
Fix icon for about:sync-tabs on Firefox RTL r=markh

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/50e969d31a60

Comment 6

[Tomer Cohen :tomer]

I can verify this on nightly.

Comment 7

[Itiel]

(In reply to Tomer Cohen :tomer from comment #6)
> I can verify this on nightly.

Same here.

Comment 8

[Andrei Vaida [:avaida]]

Updating status flags based on Comment 6 and Comment 7. This is verified fixed thanks to Tomer and ItielMaN.