Closed Bug 1326546 Opened 5 years ago Closed 5 years ago
Fix icon for about:sync-tabs on Firefox RTL
59 bytes, text/x-review-board-request
The icon in about:sync-tabs appears behind the search box on Firefox RTL builds. The fix I suggest is to change tweak the background-position-x to 100% on the headers class for RTL builds.
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
Comment on attachment 8822887 [details] Bug 1326546 - Fix icon for about:sync-tabs on Firefox RTL https://reviewboard.mozilla.org/r/101662/#review102116 Since these three files are identical (I've compared checksums), is there a reason why not merge them into a shared stylesheet? Should I file another bug and fix it as well?
Comment on attachment 8822887 [details] Bug 1326546 - Fix icon for about:sync-tabs on Firefox RTL https://reviewboard.mozilla.org/r/101662/#review102156 I don't have any problem with this, but note that about:sync-tabs is deprecated and will soon be removed - the new UI is available from the "hamburger" menu's "Sync Tabs" entry and/or a "Synced Tabs" sidebar. Thus, I wouldn't bother with another bug to consolidate these style sheets.
Attachment #8822887 - Flags: review?(markh) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/50e969d31a60 Fix icon for about:sync-tabs on Firefox RTL r=markh
I can verify this on nightly.
(In reply to Tomer Cohen :tomer from comment #6) > I can verify this on nightly. Same here.
You need to log in before you can comment on or make changes to this bug.